Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): create email and slack notifications #24

Conversation

Aeternalis-Ingenium
Copy link
Owner

  • Upload plots from example.
  • Create Notification abstract class.
  • Create EmailNotification abstract class.
  • Create SlackNotification abstract class.
  • Create unit test for both notification classes.
  • Adjust unit tests for new methods.

This method is used primarily for reporting or when sending notification.
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d8db2a) 100.00% compared to head (2cfff64) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             trunk       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        28    +5     
  Lines          111       148   +37     
=========================================
+ Hits           111       148   +37     
Flag Coverage Δ
anomalytics 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Aeternalis-Ingenium Aeternalis-Ingenium force-pushed the feature/notification/create_email_and_slack_notifications branch from e3073e7 to 42928c2 Compare December 10, 2023 23:57
@Aeternalis-Ingenium Aeternalis-Ingenium merged commit 46988b4 into trunk Dec 11, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants