-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notification): create email and slack notifications #24
Merged
Aeternalis-Ingenium
merged 23 commits into
trunk
from
feature/notification/create_email_and_slack_notifications
Dec 11, 2023
Merged
feat(notification): create email and slack notifications #24
Aeternalis-Ingenium
merged 23 commits into
trunk
from
feature/notification/create_email_and_slack_notifications
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures for unittesting
…fication via SMTP
This method is used primarily for reporting or when sending notification.
…rather than float
…private attributes
…e notification process
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 28 +5
Lines 111 148 +37
=========================================
+ Hits 111 148 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Aeternalis-Ingenium
force-pushed
the
feature/notification/create_email_and_slack_notifications
branch
from
December 10, 2023 23:57
e3073e7
to
42928c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification
abstract class.EmailNotification
abstract class.SlackNotification
abstract class.