Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airtime #4

Merged
merged 2 commits into from
Feb 5, 2016
Merged

Airtime #4

merged 2 commits into from
Feb 5, 2016

Conversation

habbes
Copy link
Contributor

@habbes habbes commented Feb 5, 2016

Implementation of the airtime API.

I referred to the implementation of the the sms API.

@habbes habbes mentioned this pull request Feb 5, 2016
@ianjuma
Copy link
Contributor

ianjuma commented Feb 5, 2016

I will merge this. I think it's fine. We need testing @habbes maybe @aksalj can review the promise logic

@ianjuma
Copy link
Contributor

ianjuma commented Feb 5, 2016

@habbes updated the README.md

ianjuma added a commit that referenced this pull request Feb 5, 2016
@ianjuma ianjuma merged commit bc00082 into AfricasTalkingLtd:master Feb 5, 2016
@aksalj
Copy link
Collaborator

aksalj commented Feb 5, 2016

looks good 👍

@habbes
Copy link
Contributor Author

habbes commented Feb 5, 2016

@ianjuma, let me add the tests

@aksalj
Copy link
Collaborator

aksalj commented Feb 5, 2016

@habbes oh yeah, tests!

@habbes
Copy link
Contributor Author

habbes commented Feb 5, 2016

I've added the tests but my npm is broken. So maybe you could verify them meanwhile.

@aksalj
Copy link
Collaborator

aksalj commented Feb 5, 2016

@habbes I can't see any new pull requests :(

@habbes
Copy link
Contributor Author

habbes commented Feb 5, 2016

I've fixed a bug preventing send airtime to multiple recipients and added a few more test cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants