Fix CAST expressions with dotted identifiers of more than 3 parts #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser was failing when using
CAST()
on dotted identifiers with more than 3 parts (e.g.,some.long.json.path
). This worked fine in regular SELECT expressions but failed specifically within CAST expressions.Root Cause
The
parseColumnCastExpr
function was callingparseColumnExpr
to parse the first argument of CAST expressions. However,parseColumnExpr
doesn't use precedence-based parsing, so whenparseIdentOrFunction
eagerly consumed up to 3 parts of a dotted identifier (database.table.column), any remaining parts were left unparsed, causing the parser to expect "AS" or "," but find "." instead.Solution
Changed
parseColumnCastExpr
to useparseExpr
instead ofparseColumnExpr
. TheparseExpr
function uses precedence-based parsing which properly handles chains of dot operations viaIndexOperation
nodes for identifiers with 4+ parts.Examples
Before (failing):
After (working):
Backward Compatibility
Ident
orColumnIdentifier
(unchanged behavior)ColumnIdentifier
for the first 3 parts + chain ofIndexOperation
s for remaining partsFixes #187.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.