Skip to content

Conversation

piyushsingariya
Copy link
Contributor

Enabling parsing for type hints in JSON column type

@git-hulk
Copy link
Member

@piyushsingariya Thanks for your enhancement. Could you please run make update_test to update the test suite?

@git-hulk
Copy link
Member

Looks good, except that it needs to run make update_test to re-generate the test snapshot.

@piyushsingariya
Copy link
Contributor Author

hi @git-hulk thanks for responding, I've executed the said command and added the changes to git.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18088673212

Details

  • 61 of 76 (80.26%) changed or added relevant lines in 2 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 50.231%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/ast.go 31 34 91.18%
parser/parser_column.go 30 42 71.43%
Files with Coverage Reduction New Missed Lines %
parser/parser_column.go 13 71.46%
Totals Coverage Status
Change from base Build 17906860225: 0.05%
Covered Lines: 7382
Relevant Lines: 14696

💛 - Coveralls

@git-hulk git-hulk merged commit 341967c into AfterShip:master Sep 29, 2025
2 checks passed
@git-hulk
Copy link
Member

@piyushsingariya, thanks for your enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants