Skip to content

Parse compression codecs with no parameters #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Parse compression codecs with no parameters #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions parser/parser_column.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,13 +1142,15 @@ func (p *Parser) tryParseCompressionCodecs(pos Pos) (*CompressionCodec, error) {
if err != nil {
return nil, err
}
// consume comma
if err := p.expectTokenKind(TokenKindComma); err != nil {
return nil, err
}
name, err = p.parseIdent()
if err != nil {
return nil, err

if p.matchTokenKind(TokenKindComma) {
if err := p.expectTokenKind(TokenKindComma); err != nil {
return nil, err
}
name, err = p.parseIdent()
if err != nil {
return nil, err
}
}
}

Expand Down
3 changes: 3 additions & 0 deletions parser/testdata/ddl/create_table_codec_no_args.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
CREATE TABLE shark_attacks (
timestamp DateTime CODEC(DoubleDelta),
);
7 changes: 7 additions & 0 deletions parser/testdata/ddl/format/create_table_codec_no_args.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
-- Origin SQL:
CREATE TABLE shark_attacks (
timestamp DateTime CODEC(DoubleDelta),
);

-- Format SQL:
CREATE TABLE shark_attacks (timestamp DateTime CODEC(DoubleDelta, DoubleDelta));
78 changes: 78 additions & 0 deletions parser/testdata/ddl/output/create_table_codec_no_args.sql.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
[
{
"CreatePos": 0,
"StatementEnd": 0,
"OrReplace": false,
"Name": {
"Database": null,
"Table": {
"Name": "shark_attacks",
"QuoteType": 1,
"NamePos": 13,
"NameEnd": 26
}
},
"IfNotExists": false,
"UUID": null,
"OnCluster": null,
"TableSchema": {
"SchemaPos": 27,
"SchemaEnd": 72,
"Columns": [
{
"NamePos": 33,
"ColumnEnd": 70,
"Name": {
"Ident": {
"Name": "timestamp",
"QuoteType": 1,
"NamePos": 33,
"NameEnd": 42
},
"DotIdent": null
},
"Type": {
"Name": {
"Name": "DateTime",
"QuoteType": 1,
"NamePos": 43,
"NameEnd": 51
}
},
"NotNull": null,
"Nullable": null,
"DefaultExpr": null,
"MaterializedExpr": null,
"AliasExpr": null,
"Codec": {
"CodecPos": 52,
"RightParenPos": 70,
"Type": {
"Name": "DoubleDelta",
"QuoteType": 1,
"NamePos": 58,
"NameEnd": 69
},
"TypeLevel": null,
"Name": {
"Name": "DoubleDelta",
"QuoteType": 1,
"NamePos": 58,
"NameEnd": 69
},
"Level": null
},
"TTL": null,
"Comment": null,
"CompressionCodec": null
}
],
"AliasTable": null,
"TableFunction": null
},
"Engine": null,
"SubQuery": null,
"HasTemporary": false,
"Comment": null
}
]