Fix the printing order of the EngineExpr.String() method #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the printing order of the EngineExpr.String() method, as placing Settings before Order BY can result in SQL execution errors
eg: CREATE TABLE IF NOT EXISTS test(id Int64, name String, age Int8, timestamp Int64) ENGINE = MergeTree() PARTITION BY toYYYYMMDD(toDateTime(timestamp / 1000)) SETTINGS index_granularity=100 ORDER BY (name, timestamp)
errors info:
Syntax error: failed at position 190 (ORDER):
CREATE table IF NOT EXISTS test(id Int64, name String, age Int8, timestamp Int64) ENGINE = MergeTree() PARTITION BY toYYYYMMDD(toDateTime(timestamp / 1000)) SETTINGS index_granularity=100 ORDER BY (name, timestamp)
Expected one of: EMPTY AS, CLONE AS, AS, COMMENT, INTO OUTFILE, FORMAT, SETTINGS, ParallelWithClause, PARALLEL WITH, end of query