Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic swingset upgrade actions #8287

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Aug 31, 2023

closes: #8279

Description

Builds on #8112 to run the core proposals part of an upgrade to completion within the upgrade block.

Security Considerations

With an infinite meter, there is a risk that a buggy core proposal or the remaining Swingset work executed before may never run to completion and effectively stall the chain.

Scaling Considerations

This will cause all upgrade work to happen in the upgrade block, which may take arbitrarily long.

Documentation Considerations

None

Testing Considerations

Updated the docker test to verify the network vat is available as soon as the pre test starts, however the docker test infra does not make it possible to test this immediately once the upgrade block is committed, so really it's a best effort.

Upgrade Considerations

Yes

@mhofman
Copy link
Member Author

mhofman commented Aug 31, 2023

Best reviewed commit-by-commit and white space hidden

@michaelfig
Copy link
Member

I'll have a look at this tomorrow. When you're up-and-about, can you PTAL at https://github.com/Agoric/agoric-sdk/actions/runs/6032610362/job/16368096857?pr=8287#step:5:25 ?

2023-08-31T03:20:37.830Z fake-chain: Cannot boot sim chain: (TypeError#1)
TypeError#1: Cannot destructure property 'beans_per_unit' of 'params' as it is undefined.

  at parseParams (packages/cosmic-swingset/src/params.js:35:21)
  at doBlockingSend (packages/cosmic-swingset/src/launch-chain.js:745:40)

@mhofman
Copy link
Member Author

mhofman commented Aug 31, 2023

Yeah I missed an update to synthetic blocking sends created by simchain. The real chain will have params on the bootstrap block, so the sim chain should too.

@mhofman mhofman force-pushed the mhofman/8279-atomic-swingset-upgrade-plan branch from 0f63e41 to 6330963 Compare August 31, 2023 22:05
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for sorting out the prioritization that I balked at. :)

packages/deployment/upgrade-test/Dockerfile Outdated Show resolved Hide resolved
@mhofman mhofman force-pushed the mhofman/8279-atomic-swingset-upgrade-plan branch from 2c3d6c5 to b1e98d2 Compare September 1, 2023 16:16
@mhofman mhofman added the automerge:rebase Automatically rebase updates, then merge label Sep 1, 2023
@mergify mergify bot merged commit 52bc8ec into master Sep 1, 2023
74 checks passed
@mergify mergify bot deleted the mhofman/8279-atomic-swingset-upgrade-plan branch September 1, 2023 17:38
@mhofman mhofman restored the mhofman/8279-atomic-swingset-upgrade-plan branch September 2, 2023 01:01
mhofman pushed a commit that referenced this pull request Nov 8, 2023
…gset-upgrade-plan

Atomic swingset upgrade actions
mhofman pushed a commit that referenced this pull request Nov 10, 2023
…gset-upgrade-plan

Atomic swingset upgrade actions
mhofman pushed a commit that referenced this pull request Jan 13, 2024
…gset-upgrade-plan

Atomic swingset upgrade actions
mhofman pushed a commit that referenced this pull request Jan 15, 2024
…gset-upgrade-plan

Atomic swingset upgrade actions
mhofman pushed a commit that referenced this pull request Jan 15, 2024
…gset-upgrade-plan

Atomic swingset upgrade actions
mhofman pushed a commit that referenced this pull request Jan 19, 2024
…gset-upgrade-plan

Atomic swingset upgrade actions
mhofman pushed a commit that referenced this pull request Jan 19, 2024
…gset-upgrade-plan

Atomic swingset upgrade actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run upgrade plan to completion during upgrade block
2 participants