feat: postalSvc contract forwards payments using namesByAddress (prototype)

[dckc]

Description

This contract is a reusable component for sending payments using namesByAddress to look up a depositFacet.
A contract such as GiMiX or swaparoo only needs this instance in its terms.

Or an offer can go straight to this contract. The script here starts the contract with the Zoe Fee and Invitation issuers.

It's something of a work-around for the regression in the wallet where this feature wasn't shipped in production.
I'm not sure it should be merged, let alone shipped in production. Maybe it should be moved to an example app.

cc @michaelfig @samsiegart @dtribble

Security Considerations

TODO:

• add missing pattern guards
• make upgradeable?
• integration test on a chain
• what forms of docs?
• creatorFacet method to add issuers?
• governed API to add issuers?

Testing Considerations

currently:

agoric-sdk/packages/zoe$ yarn test test/unitTests/contracts/gimix/test-postalSvc.js 
$ ava --verbose test/unitTests/contracts/gimix/test-postalSvc.js

[bundleTool] bundles/ bundle-gimix.js valid: 121 files bundled at 2023-11-18T00:58:21.248Z with size 1017305 
postalSvc issuers [ 'IST', 'Invitation' ]
  ✔ deliver payment using address (360ms)
    ℹ send IST with public facet to agoric1receiver
    ℹ make offer to send IST, Invitation to agoric1receiver
start-postalSvc postalSvc started
  ─

  1 test passed

[Chris-Hibbert]

Seems fine. Some requests for mostly minor cleanups or clarification. The for loop issue seems substantive.

[Chris-Hibbert]

earlier failures will block later attempts. A Promise.all() would try them in parallel, so that they can succeed independently.

[Chris-Hibbert]

Why is this helpful?

[dckc]

to override installBundleID

p.s. thanks for taking a look.

[Chris-Hibbert]

I don't get it. It looks like it passes installBundleID() through just like it does for all the other methods it supports. In a test, why is this better than just passing zoeMethods through? Did I misread something?

[dckc]

the real zoe is an exo, so you can't just go { ...zoe, installBundleID: myMockInstallBundle }. (I should probably document what happens if you try.)

wrapZoe takes the zoe exo and gives you back a plain record/object, where you can override methods using spread expressions like that:

    const zoe = Far('ZoeService', {
      ...wrapZoe(zoeService),
      installBundleID: install1BundleID,
    });

[erights]

Just so you're aware of bindAllMethods

agoric-sdk/packages/internal/src/method-tools.js

Line 77 in 6d9ae67

/**

As it says there, bindAllMethods was only a transitional measure until replaced by code this PR's wrapZoe, so no change suggested. Just FYI.

[dckc]

Thanks; I was only vaguely aware of it. But I'm leery to use stuff from @agoric/internal, because it's a private package, and I was thinking this contract should probably be outside the SDK.

[dckc]

work moved to agoric-labs/ag-power-tools#2