Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stkAtom price feed #9394

Merged
merged 2 commits into from
May 28, 2024
Merged

stkAtom price feed #9394

merged 2 commits into from
May 28, 2024

Conversation

Chris-Hibbert
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert commented May 21, 2024

closes: #9393

Description

Add a new priceFeed for StkATOM.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

[Edited]: added verification to an existing test in A3P.

Upgrade Considerations

This completes the sustainability upgrade by replacing the only priceFeed that wasn't handled in the A3P tests.

@Chris-Hibbert Chris-Hibbert added contract-upgrade oracle Related to on-chain oracles. next-release about next agoric-sdk or endo release labels May 21, 2024
@Chris-Hibbert Chris-Hibbert self-assigned this May 21, 2024
@Chris-Hibbert Chris-Hibbert changed the base branch from master to 8400-upgradeScaledPAs May 21, 2024 17:27
@Chris-Hibbert Chris-Hibbert requested a review from turadg May 21, 2024 17:27
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this have a test?

Copy link

cloudflare-pages bot commented May 21, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5a5630a
Status: ✅  Deploy successful!
Preview URL: https://0a27b584.agoric-sdk.pages.dev
Branch Preview URL: https://9393-stkatom-pricefeed.agoric-sdk.pages.dev

View logs

@Chris-Hibbert
Copy link
Contributor Author

Shouldn't this have a test?

It now has a test.

@Chris-Hibbert Chris-Hibbert added automerge:rebase Automatically rebase updates, then merge and removed automerge:rebase Automatically rebase updates, then merge labels May 21, 2024
Base automatically changed from 8400-upgradeScaledPAs to master May 24, 2024 21:54
@Chris-Hibbert Chris-Hibbert added the automerge:rebase Automatically rebase updates, then merge label May 28, 2024
@mergify mergify bot merged commit 08f8549 into master May 28, 2024
63 checks passed
@mergify mergify bot deleted the 9393-stkAtom-priceFeed branch May 28, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge contract-upgrade next-release about next agoric-sdk or endo release oracle Related to on-chain oracles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add priceFeed/scaledPriceAuthority proposal for stkAtom
2 participants