Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add priceFeed/scaledPriceAuthority proposal for stkAtom #9393

Closed
Chris-Hibbert opened this issue May 21, 2024 · 1 comment · Fixed by #9394
Closed

add priceFeed/scaledPriceAuthority proposal for stkAtom #9393

Chris-Hibbert opened this issue May 21, 2024 · 1 comment · Fixed by #9394
Assignees
Labels
contract-upgrade enhancement New feature or request next-release about next agoric-sdk or endo release oracle Related to on-chain oracles.

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

Upgrade 16 will need to replace all priceFeeds and upgrade all scaledPriceAuthorities. #9044 added proposals to replace the priceFeeds in A3P. #9382 upgrades scaledPriceAuthorities there. MainNet also has oracles for stkATOM, which is not present on A3P.

Description of the Design

Add appropriate proposals for stkATOM for the release.

Security Considerations

No security implications

Scaling Considerations

Single use, so not relevant. Doing this upgrade resolves a scaling problem, and doesn't introduce any new issues.

Test Plan

Tough unless we have a MainNet clone. We'll just have to monitor dataDog.

Upgrade Considerations

We'll be upgrading or replacing several contracts. Get an up-to-date list of price feeds.

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request contract-upgrade oracle Related to on-chain oracles. next-release about next agoric-sdk or endo release labels May 21, 2024
@Chris-Hibbert Chris-Hibbert self-assigned this May 21, 2024
@Chris-Hibbert
Copy link
Contributor Author

Oh, yeah. #9382 upgrades all scaledPriceAuthorities, so no additional work is needed.

@mergify mergify bot closed this as completed in #9394 May 28, 2024
mergify bot added a commit that referenced this issue May 28, 2024
closes: #9393

## Description

Add a new priceFeed for StkATOM.

### Security Considerations

None

### Scaling Considerations

None

### Documentation Considerations

None

### Testing Considerations

[**Edited**]: added verification to an existing test in A3P.

### Upgrade Considerations

This completes the sustainability upgrade by replacing the only
priceFeed that wasn't handled in the A3P tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade enhancement New feature or request next-release about next agoric-sdk or endo release oracle Related to on-chain oracles.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant