-
Notifications
You must be signed in to change notification settings - Fork 27
Add support for configuration of timestamp extractor #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/main/java/io/aiven/kafka/connect/transforms/ExtractTimestampConfig.java
Outdated
Show resolved
Hide resolved
src/test/java/io/aiven/kafka/connect/transforms/ExtractTimestampConfigTest.java
Outdated
Show resolved
Hide resolved
@willyborankin left couple comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of comments
src/main/java/io/aiven/kafka/connect/transforms/ExtractTimestampConfig.java
Outdated
Show resolved
Hide resolved
eac7340
to
5cd3d5e
Compare
src/main/java/io/aiven/kafka/connect/transforms/ExtractTimestampConfig.java
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTimestamp.java
Outdated
Show resolved
Hide resolved
5cd3d5e
to
32c311c
Compare
src/main/java/io/aiven/kafka/connect/transforms/ExtractTimestampConfig.java
Outdated
Show resolved
Hide resolved
So, effectively we need this set of tests:
Some conversion according to the resolution should be done here. Also:
No conversion must be done here. Exactly the moment of time that is on the input should be on the output, despite the resolution setting. There might be some way to use |
c501dcc
to
ce94da1
Compare
@ivanyu all done |
ce94da1
to
c677cd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small changes, but overall LGTM
src/test/java/io/aiven/kafka/connect/transforms/ExtractTimestampTest.java
Outdated
Show resolved
Hide resolved
add timestamp.resolution property to config timestamp extractor There are two configuration parameter values: - milliseconds - extracts timestamp from the field or the key and puts it as is in milliseconds - seconds - extract seconds and put it in milliseconds
beffcdf
to
c3f1928
Compare
@ivanyu squashed |
Add
timestamp.resolution
property to config timestamp extractorThere are two configuration parameter values:
milliseconds
- extracts timestamp from the field or the key and puts it as is in millisecondsseconds
- extracts timestamp in seconds put in it in milliseconds