Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Vite 5.0 #647

Merged
merged 3 commits into from
Jan 15, 2024
Merged

feat: Support Vite 5.0 #647

merged 3 commits into from
Jan 15, 2024

Conversation

peterbud
Copy link
Contributor

Description

This PR upgrades dependencies to Vite 5 and @types/node 18

Fixes #636

Additional context

I have also checked all examples and fixed build issues. All seem working OK.

There is still one warning left: The CJS build of Vite's Node API is deprecated. I have traced that and this warning is dependent on the jiti packages. Once jiti will switch to ESM being the native import/loading mechanism in v2 this warning will go away.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Dec 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codesandbox bot commented Dec 12, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit c4caf39
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/65780918dea6fc0008bdf45c
😎 Deploy Preview https://deploy-preview-647--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit c4caf39
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/65780918124c1500082c46bc
😎 Deploy Preview https://deploy-preview-647--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit c4caf39
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/657809186bbdbb0008bf8bbd
😎 Deploy Preview https://deploy-preview-647--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit c4caf39
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/6578091808a32e00086721c4
😎 Deploy Preview https://deploy-preview-647--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@peterbud peterbud changed the title Support Vite 5.0 build: Support Vite 5.0 Dec 12, 2023
@AndreiSoroka
Copy link

Hello, just interesting. Does anyone have a vision of when this PR will be merged? :)

@50rayn
Copy link
Contributor

50rayn commented Dec 25, 2023

I suppose @Akryum should take a look and confirm, if everything is OK. I am also waiting for this update. Big thanks to @peterbud 🙏.

@AndreiSoroka
Copy link

Happy New Year, I hope to see this PR next year 😄

@xaddict
Copy link

xaddict commented Jan 10, 2024

any updates? :)

@KevinBazimo
Copy link

I really need this update, please expedite the approval.

@Akryum Akryum changed the title build: Support Vite 5.0 feat: Support Vite 5.0 Jan 15, 2024
@Akryum Akryum merged commit 0167c43 into histoire-dev:main Jan 15, 2024
13 of 14 checks passed
@AndreiSoroka
Copy link

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite 5 Support
6 participants