Check for global document rather than exports with INTO HTML
#1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, off topic, but an interesting idea for a user function would be one which could do |
|
Awesome! |
mathiasrw
changed the title
document rather than exports with INTO HTMLdocument rather than exports with INTO HTML
|
Released as part of https://github.com/AlaSQL/alasql/releases/tag/v2.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for one to set a
global.document = documentin Node via the likes of JSDom to query HTML one has parsed in Node (on the server side).A better approach might be allowing the user to supply the document object as an option, but as it seems you don't really accept options in the constructor, I thought this might be as easy.
One other item this PR doesn't handle is that it is possible that
SELECT * FROM TXT('#one')could be supported in Node too.