-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSVariable variable names invalid, possible docs update? #31
Comments
Good catch. This file is not really used and what I think happened is with the last major refactor the output file was altered and not caught. I am working on a major release for the Tokens that removes all legacy Orion and Classic support, this update will be added to that branch. I will also retroactive update the previous version of Tokens to address this bug. |
## [2.12.3](v2.12.2...v2.12.3) (2020-11-14) ### Bug Fixes * [#31](#31) update config to output correct data from Tokens ([7e1dc82](7e1dc82))
🎉 This issue has been resolved in version 2.12.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [3.0.0](v2.12.3...v3.0.0) (2020-11-14) ### Bug Fixes * [#31](#31) update config to output correct data from Tokens ([c548d98](c548d98)) ### Build System * update repo url ([e0a8701](e0a8701)) ### Performance Improvements * remove deprecated tokens ([7545302](7545302)) ### BREAKING CHANGES * forcing chance; previous build failed * This update will effectively remove all legacy colors and Orion references
🎉 This issue has been resolved in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sorry, there might be a few issues rolled into this. I tried playing with jss and went for our Javascript tokens but wasn't sure how to consume them, so I started with our Auro docs. There are several JS* files. I noticed
JSData--color.js
has an object structure and I can pull the color like so:Issue 1
I think token documentation for ESModules might be out of date. It references title case variables like
ColorAlertNotificationOnLight
fromJSVariables--color.js
but current variable names are kebab (see below). Can I useJSData--color.js
too?Issue 2
Next, because the docs suggested
JSVariables--color.js
I looked for the titlecase variables. From the StyleDictionary configuration, and from a quick search it looks like this doesn't conform with rules for accepted identifiers (variable names). The question here is a bit more complicated: the object syntax above is fine, what was the hopeful goal of autogenerated variable names vs. object? Assuming we need the variable name case, I think this would be fixed by using camel or title case (just not kebab).The text was updated successfully, but these errors were encountered: