Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major release #32

Merged
merged 5 commits into from
Nov 14, 2020
Merged

Major release #32

merged 5 commits into from
Nov 14, 2020

Conversation

blackfalcon
Copy link
Member

@blackfalcon blackfalcon commented Nov 12, 2020

Alaska Airlines Pull Request

This update is a BREAKING CHANGE update that totally removes any support for Orion or Classic token support.

Per this release, the npm package has been renamed to @alaskaairux/design-tokens. This will allow for the install of the new Tokens package while having the legacy package installed at the same time. The intent is that this will make it easier to move over to the new conventions and systematically remove all legacy Classic or Orion references.

The following is an updated list of currently supported Design Token resources.

└── tokens
   ├── CSSCustomProperties.css
   ├── CSSCustomPropertiesColorRGB.css
   ├── CSSOpacityProperties.scss
   ├── CSSSizeCustomProperties.css
   ├── JSData--color.js
   ├── JSObject--allTokens.js
   ├── JSVariables--color.js
   ├── SCSSOpacityVariables.scss
   ├── SCSSVariableMap.scss
   ├── SCSSVariables.scss
   ├── SassCustomProperties.scss
   ├── SassCustomPropertiesColorRGB.scss
   └── SassSizeCustomProperties.scss

Other notable changes

The following files have been updated to assume the auro prefix.

   ├── JSData--color.js
   ├── JSObject--allTokens.js
   ├── JSVariables--color.js

In regards to JSVariables--color.js, Issue #31 reported that the names of variables were incorrect. E.g.

export const color-background-lighter = "#f8f8f8";

This was corrected and the output from the previous version is now

export const ColorBackgroundLighter = "#f8f8f8";

In this MAJOR release, these same variables will be output with the Auro prefix. Also noted is that any variable that was for use with Orion or Classic, they are deleted per this release. See the Auro docsite for a complete list of deprecated/deleted tokens.

export const AuroColorBackgroundLighter = "#f8f8f8";

In regards to the JSObject--allTokens.js and JSData--color.js files, the convention is the following:

"name": "auro-color-alert-notification-on-light",

All other Auro tokens are already using the auro prefix, so there are no changes there.

$auro-color-alert-notification-on-light: #0074cb;
--auro-color-alert-notification-on-light: #0074cb;

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • BREAKING CHANGE

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Orion Design System Team

@AuroDesignSystem AuroDesignSystem merged commit d9728d3 into master Nov 14, 2020
@AuroDesignSystem AuroDesignSystem deleted the majorRelease branch November 14, 2020 02:27
@AuroDesignSystem
Copy link
Collaborator

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants