Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group data_refinery_workers tests. #3136

Conversation

arkid15r
Copy link
Contributor

@arkid15r arkid15r commented Nov 2, 2022

Issue Number

Resolves #3134

Purpose/Implementation Notes

  • Move all tests to tests directory
  • Add separate settings file (tests/settings.py).
  • Refactor import according to the new structure.

Methods

N/A

Types of changes

N/A

Functional tests

N/A

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

N/A

arkid15r and others added 10 commits June 24, 2022 10:06
Bumps [django](https://github.com/django/django) from 3.2.7 to 3.2.15.
- [Release notes](https://github.com/django/django/releases)
- [Commits](django/django@3.2.7...3.2.15)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [django](https://github.com/django/django) from 3.2.7 to 3.2.15.
- [Release notes](https://github.com/django/django/releases)
- [Commits](django/django@3.2.7...3.2.15)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [django](https://github.com/django/django) from 3.2.7 to 3.2.15.
- [Release notes](https://github.com/django/django/releases)
- [Commits](django/django@3.2.7...3.2.15)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Add quotes around $OPTARG.
  - exclude terraform files
  - exclude VSCode project files
  - exclude `errors.txt` file
Add separate settings  file (tests/settings.py).
Refactor import according to the new structure.
@arkid15r arkid15r linked an issue Nov 2, 2022 that may be closed by this pull request
Update pre-commit config. Bump black version.
…-3.2.15

Bump django from 3.2.7 to 3.2.15 in /api
…ta_refinery_workers/downloaders/django-3.2.15

Bump django from 3.2.7 to 3.2.15 in /workers/data_refinery_workers/downloaders
…ngo-3.2.15

Bump django from 3.2.7 to 3.2.15 in /common
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r changed the base branch from feature/term3-refactoring to feature/automatic-accessions February 9, 2023 17:15
@arkid15r arkid15r merged commit 344deb4 into feature/automatic-accessions Feb 9, 2023
@arkid15r arkid15r deleted the ark/3134-consolidate-data-refinery-workers-tests branch February 9, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate data_refinery_workers tests
2 participants