Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro to R Fixes #126

Merged
merged 10 commits into from
Jul 16, 2019
Merged

Intro to R Fixes #126

merged 10 commits into from
Jul 16, 2019

Conversation

cansavvy
Copy link
Contributor

@cansavvy cansavvy commented Jul 12, 2019

This PR closes #110.

For this module, this leaves only the more diagrams issue and adding more simple exercises issue #125 to be addressed in this module.

This PR includes a lot of little changes. If this feels like too much to review at once, let me know and I can try to chunk it more. But to make it more clear the changes I've made; here's the list:

Typo fixes

  • Got rid of extra space in df <- data.frame(nums , words, color_vector)
  • *FE*males who are older than 100 months
  • Bullet spacing for resources is fixed
  • Indent of "vector" bullet point

Organizational changes

  • Re-order read in metadata.tsv AFTER using file.exist
  • Move question "Why do you suppose we don't have a comma to subset this object?" to after the code chunk - @cbethell 's suggestion

Explanation adds

  • Explain a TSV file, CSV file, RDS file
  • Explain %in%
  • Explain dplyr::join
  • Explain negative indices

PR Checklist

  • Run a linter - (NA Most of the adds are words and not code so a linter would not help much here)
  • Set the seed (if applicable)
  • Comments and/or documentation up to date
  • Double check your paths (NA - no extra files are added)
  • Check headline numbering (NA - sections are not numbered)
  • Spell check any Rmd file or md file
  • Restart R and run all notebooks fresh and save

Copy link
Contributor

@cbethell cbethell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The subset question is much more clear, and so are the explanations you added.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's make sure to get that plot displayed before merging.

intro-to-R-tidyverse/02-intro_to_tidyverse.Rmd Outdated Show resolved Hide resolved
@cansavvy cansavvy merged commit f49cd07 into master Jul 16, 2019
@cansavvy cansavvy deleted the cansav09/intro_to_R_fixes branch July 29, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intro-to-R-tidyverse module fixes and improvements
3 participants