[ACS-3513] [ACS-3515] Create, edit and delete rule set link #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomikaArome
requested review from
nikita-web-ua,
MichalKinas and
AleksanderSklorz
| @@ -38,7 +38,8 @@ export interface EditRuleDialogOptions { | |||
| templateUrl: './edit-rule-dialog.smart-component.html', | |||
| styleUrls: ['./edit-rule-dialog.smart-component.scss'], | |||
| encapsulation: ViewEncapsulation.None, | |||
| host: { class: 'aca-edit-rule-dialog' } | |||
| host: { class: 'aca-edit-rule-dialog' }, | |||
| providers: [{ provide: ActionsService, useClass: ActionsService }] | |||
There was a problem hiding this comment.
Probably can be shorter:
providers: [ActionsService]
| @@ -0,0 +1,59 @@ | |||
| <div mat-dialog-title class="aca-rule-set-picker__header"> | |||
| <div class="aca-rule-set-picker__header__title"> | |||
There was a problem hiding this comment.
Not sure if you want to cover accessibility problems here but I think that if you run axe tool then you will get issue that you should to use h1 tag because you need some header on page.
MichalKinas
approved these changes
Nov 24, 2022
nikita-web-ua
approved these changes
Nov 24, 2022
AleksanderSklorz
approved these changes
Nov 24, 2022
TomikaArome
deleted the
feature/dev-thunter-ACS-3513-create-rule-set-link
branch
|
Unit tests have been split from this ticket to make the code freeze deadline. They will be covered in https://alfresco.atlassian.net/browse/ACS-4070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-3513
https://alfresco.atlassian.net/browse/ACS-3515
What is the new behaviour?
A new dialog for linking & editing the linked rule set.
Button in the toolbar of the manage rule screen for linking a rule that opens the dialog.
Button in the header of the linked rule set to edit the link which opens the same dialog.
Button also in the header of the linked rule set to remove the link which opens a confirmation dialog.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: