Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACA-4652] Run unit tests as one GH job, add e2es as GH job #2997

Merged
merged 63 commits into from
Mar 2, 2023
Merged

[ACA-4652] Run unit tests as one GH job, add e2es as GH job #2997

merged 63 commits into from
Mar 2, 2023

Conversation

MichalKinas
Copy link
Contributor

@MichalKinas MichalKinas commented Feb 17, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

E2es are run only by Travis. https://alfresco.atlassian.net/browse/ACA-4652

What is the new behaviour?

E2es are now run as part of pull request GH workflow. All before install setup and ADF linking were migrated as well.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pr-triage pr-triage bot added the PR: draft label Feb 17, 2023
@MichalKinas MichalKinas marked this pull request as ready for review February 17, 2023 09:23
gionn
gionn reviewed Feb 23, 2023
View reviewed changes
.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
.github/actions/after-e2e/action.yml Outdated Show resolved Hide resolved
.github/actions/after-e2e/action.yml Outdated Show resolved Hide resolved
.github/actions/after-e2e/action.yml Outdated Show resolved Hide resolved
@MichalKinas MichalKinas force-pushed the feature/dev-mkinas-ACA-4652-migrate-e-2-e branch 2 times, most recently from 2b9c1c7 to f0974c2 Compare March 1, 2023 09:56
@CLAassistant
Copy link

CLAassistant commented Mar 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MichalKinas
[ACA-4652] Disable failing download on Travis, npm ci in before e2e
8b25f31
@MichalKinas
[ACA-4652] Missing shell
e597f7d
@MichalKinas
[ACA-4652] Restore artifact download
37e3973
@MichalKinas
[ACA-4652] Download smartrunner artifact only when present
68e3cfe
@MichalKinas
[ACA-4652] Check run attempt
9e3cbfa
@MichalKinas
[ACA-4652] Correct attempt check
a4c49d7
@MichalKinas
[ACA-4652] Stop running e2es in Travis for now
2eb0829
@MichalKinas
[ACA-4652] Run Travis e2es again, add test suite id
3f3f654
@MichalKinas
[ACA-4652] Add test suite id to after e2e action
73d749e
@MichalKinas
[ACA-4652] Remove additional install
bb256f2
@MichalKinas
[ACA-4652] CR fixes, remove some Travis config that is already migrated
e9a30f9
@MichalKinas
[ACA-4652] Cleanup setup leftover
25cf9b8
@MichalKinas
[ACA-4652] Propagate aws credentials
f866083
@MichalKinas
[ACA-4652] Fix aws default region
a7e1d4e
@MichalKinas
[ACA-4652] Misspelled variable fix
23ec2df
@MichalKinas
[ACA-4652] Propagate aws region
d22d950
@MichalKinas
[ACA-4652] Rename PR workflow
77bea1e
@MichalKinas
[ACA-4652] Download artifact only if bucket exists
5a52526
@MichalKinas
[ACA-4652] Run test even is aws bucket doesn't exist
16da641
@MichalKinas
[ACA-4652] Fix aws download error
110ca77
@MichalKinas
[ACA-4652] Check if file exists before downloading
b8ae604
@MichalKinas
[ACA-4652] Remove uploading/downloading e2e artifact after successful…
c30dd37 
… run
@MichalKinas MichalKinas force-pushed the feature/dev-mkinas-ACA-4652-migrate-e-2-e branch from f0974c2 to c30dd37 Compare March 1, 2023 19:17
@DenysVuika DenysVuika merged commit 01f7e3c into develop Mar 2, 2023
@DenysVuika DenysVuika deleted the feature/dev-mkinas-ACA-4652-migrate-e-2-e branch March 2, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenysVuika DenysVuika DenysVuika left review comments

@gionn gionn gionn approved these changes

@eromano eromano Awaiting requested review from eromano

@alxgomz alxgomz Awaiting requested review from alxgomz

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichalKinas @CLAassistant @gionn @DenysVuika