[ACS-7334] [E2E] Search filters - date - tests migrated to Playwright #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datguychen
requested review from
DenysVuika,
akashrathod28,
nikita-web-ua,
MichalKinas,
AleksanderSklorz,
azakrzewski-hy and
katarzynakita
datguychen
force-pushed
the
ACS-7334-Protractor-to-Playwright-E2e-test-suites-search-filters-Date-filter
branch
from
15ee3b7
to
2ffbc6c
Compare
akashrathod28
approved these changes
Apr 8, 2024
katarzynakita
approved these changes
Apr 9, 2024
...ht-shared/src/page-objects/components/search/search-filters/search-filters-date.component.ts
Show resolved
Hide resolved
|
@datguychen sonarcloud found issue, can you fix this? |
|
@AleksanderSklorz I dont think I cant fix the sonar cloud issue, because this function is built to be as reusable as possible and to avoid sonar cloud code duplication in the test file 😞 |
datguychen
force-pushed
the
ACS-7334-Protractor-to-Playwright-E2e-test-suites-search-filters-Date-filter
branch
from
d25e1ec
to
e7a31ba
Compare
AleksanderSklorz
approved these changes
Apr 15, 2024
|
datguychen
deleted the
ACS-7334-Protractor-to-Playwright-E2e-test-suites-search-filters-Date-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-7334
What is the new behaviour?
Search filters - date - tests migrated to Playwright
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: