[ACS-8063] Migrate editActions e2e from Protractor to Playwright #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katarzynakita
force-pushed
the
tests/ACS-8063-migrate-edit-actions
branch
from
85ec258
to
02a64f0
Compare
katarzynakita
force-pushed
the
tests/ACS-8063-migrate-edit-actions
branch
3 times, most recently
from
56ad82b
to
f64efd7
Compare
katarzynakita
requested review from
akashrathod28,
datguychen,
MichalKinas and
DaryaBalvanovich
MateuszHY
reviewed
Jul 23, 2024
MateuszHY
approved these changes
Jul 23, 2024
datguychen
reviewed
Jul 23, 2024
projects/aca-playwright-shared/src/page-objects/components/dataTable/mat-menu.component.ts
Show resolved
Hide resolved
projects/aca-playwright-shared/src/page-objects/components/dialogs/edit-dialog.component.ts
Outdated
Show resolved
Hide resolved
projects/aca-playwright-shared/src/page-objects/components/dialogs/edit-dialog.component.ts
Show resolved
Hide resolved
DenysVuika
approved these changes
Jul 23, 2024
katarzynakita
force-pushed
the
tests/ACS-8063-migrate-edit-actions
branch
from
43b6816
to
f7deff9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Migrated edit-folder tests from Protractor to Playwright.
Removed Protractor tests.
Removed protractor tests github pull request workflow.
Added Playwright edit-actions tests github pull request workflow.
Added additional wait in Viever tests as they were flaky.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: