[ACS-5166] Changes to Digital workspace new UI for better experience #8640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arohilaGL
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
DenysVuika
requested changes
Jun 9, 2023
lib/core/src/lib/assets/images/icon-notification-outline-default.svg
Outdated
Show resolved
Hide resolved
lib/core/src/lib/notifications/components/notification-history.component.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/notifications/components/notification-history.component.html
Outdated
Show resolved
Hide resolved
MichalKinas
reviewed
Jun 12, 2023
DenysVuika
reviewed
Jun 14, 2023
DenysVuika
approved these changes
Jun 16, 2023
DenysVuika
force-pushed
the
dev-arohila-ACS-5166
branch
from
fce1ef7
to
086e973
Compare
DenysVuika
force-pushed
the
dev-arohila-ACS-5166
branch
from
086e973
to
b6c2aed
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
DenysVuika
requested changes
Jun 19, 2023
| @@ -48,6 +49,8 @@ export class IconComponent { | |||
| set value(value: string) { | |||
| this._value = value || 'settings'; | |||
| this._isCustom = this._value.includes(':'); | |||
| this.isOutlined = this._value.includes('_outline'); | |||
| this._value = this._value.replace('_outline',''); | |||
There was a problem hiding this comment.
this is hacking of the old material icons font, and is introducing IDs that are invalid for the new Material Symbols font. this is also not going to work for cases like
<mat-icon class="adf-error-icon">error_outline</mat-icon>
DenysVuika
requested changes
Jun 19, 2023
| [matBadgeHidden]="!notifications.length" | ||
| matBadgeColor="warn" | ||
| matBadgeSize="small" | ||
| fontSet="mat-icons-outlined">notifications</mat-icon> |
There was a problem hiding this comment.
in this PR, there is no outlined font in the ADF, you are breaking the component
|
@arohilaGL you based your PR on the wrong library, you should have been using Material Icons |
|
closing in favor other PRs, also the icons for mime types needed a replacement, not a separate copies, see #8683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Design changes to new UI layout
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://alfresco.atlassian.net/browse/ACS-5166