Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPS-2159] [APPS-2163] Replaced from moment.js to date-fns #8878

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

vijayanssettu
Copy link
Contributor

@vijayanssettu vijayanssettu commented Sep 1, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
moment dependency is being used in e2e.ts file below
1.task-details.e2e.ts
2.process-filter-results.e2e.ts

What is the new behaviour?
migrated e2e's from moment to date-fns

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/APPS-2159
https://alfresco.atlassian.net/browse/APPS-2163

@arohilaGL
Copy link
Contributor

@vijayanssettu, change the title to suggest that the library is changed from moment to date-fns and not the whole e2e has been migrated.

@vijayanssettu vijayanssettu changed the title [APPS-2159] [APPS-2163] migration of e2e test cases from moment to date-fns [APPS-2159] [APPS-2163] library is changed from moment to date-fns Sep 2, 2023
@vijayanssettu vijayanssettu changed the title [APPS-2159] [APPS-2163] library is changed from moment to date-fns [APPS-2159] [APPS-2163] Replaced from moment.js to date-fns Sep 2, 2023
@vijayanssettu vijayanssettu marked this pull request as ready for review September 5, 2023 13:30
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
46.2% 46.2% Duplication

@DenysVuika DenysVuika merged commit 0933e2d into develop Sep 26, 2023
33 checks passed
@DenysVuika DenysVuika deleted the dev-vijayan-APPS-2159 branch September 26, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants