-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-6003] - waitRendition in rendition.service.ts not working #8936
Merged
dominikiwanekhyland
merged 4 commits into
develop
from
ACS-6003-community-8875-wait-rendition-in-rendition-service-ts-not-working
Sep 29, 2023
Merged
[ACS-6003] - waitRendition in rendition.service.ts not working #8936
dominikiwanekhyland
merged 4 commits into
develop
from
ACS-6003-community-8875-wait-rendition-in-rendition-service-ts-not-working
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikiwanekhyland
requested review from
swapnil-verma-gl,
MichalKinas and
AleksanderSklorz
September 26, 2023 15:16
dominikiwanekhyland
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
September 26, 2023 15:16
DenysVuika
approved these changes
Sep 26, 2023
MichalKinas
approved these changes
Sep 26, 2023
swapnil-verma-gl
approved these changes
Sep 27, 2023
lib/content-services/src/lib/common/services/rendition.service.ts
Outdated
Show resolved
Hide resolved
dominikiwanekhyland
force-pushed
the
ACS-6003-community-8875-wait-rendition-in-rendition-service-ts-not-working
branch
from
September 27, 2023 13:03
9b37af8
to
bf1bc5f
Compare
dominikiwanekhyland
requested review from
AleksanderSklorz,
DenysVuika,
swapnil-verma-gl and
MichalKinas
September 27, 2023 14:59
dominikiwanekhyland
force-pushed
the
ACS-6003-community-8875-wait-rendition-in-rendition-service-ts-not-working
branch
from
September 27, 2023 15:16
2be9175
to
8dcb951
Compare
dominikiwanekhyland
force-pushed
the
ACS-6003-community-8875-wait-rendition-in-rendition-service-ts-not-working
branch
from
September 27, 2023 15:55
8dcb951
to
1b1e255
Compare
lib/content-services/src/lib/common/services/rendition.services.spec.ts
Outdated
Show resolved
Hide resolved
AleksanderSklorz
approved these changes
Sep 28, 2023
DenysVuika
requested changes
Sep 28, 2023
lib/content-services/src/lib/common/services/rendition.services.spec.ts
Outdated
Show resolved
Hide resolved
dominikiwanekhyland
force-pushed
the
ACS-6003-community-8875-wait-rendition-in-rendition-service-ts-not-working
branch
from
September 28, 2023 10:46
d44e818
to
39a3075
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
DenysVuika
approved these changes
Sep 28, 2023
dominikiwanekhyland
deleted the
ACS-6003-community-8875-wait-rendition-in-rendition-service-ts-not-working
branch
September 29, 2023 05:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
the Retry feature from method: getRendition does not work, because of wrong condition in rendition service
https://alfresco.atlassian.net/browse/ACS-6003
What is the new behaviour?
Calling the getRendition waits until the rendition is available.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: