Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6003] - waitRendition in rendition.service.ts not working #8936

Conversation

dominikiwanekhyland
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
the Retry feature from method: getRendition does not work, because of wrong condition in rendition service

https://alfresco.atlassian.net/browse/ACS-6003

What is the new behaviour?
Calling the getRendition waits until the rendition is available.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-6003-community-8875-wait-rendition-in-rendition-service-ts-not-working branch from 9b37af8 to bf1bc5f Compare September 27, 2023 13:03
@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-6003-community-8875-wait-rendition-in-rendition-service-ts-not-working branch from 2be9175 to 8dcb951 Compare September 27, 2023 15:16
@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-6003-community-8875-wait-rendition-in-rendition-service-ts-not-working branch from 8dcb951 to 1b1e255 Compare September 27, 2023 15:55
@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-6003-community-8875-wait-rendition-in-rendition-service-ts-not-working branch from d44e818 to 39a3075 Compare September 28, 2023 10:46
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dominikiwanekhyland dominikiwanekhyland merged commit 501516c into develop Sep 29, 2023
33 checks passed
@dominikiwanekhyland dominikiwanekhyland deleted the ACS-6003-community-8875-wait-rendition-in-rendition-service-ts-not-working branch September 29, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants