[pull] master from youngyangyang04:master #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
1. 修复了 JavaScript 解法二，堆 pop 方法无法处理数组长度 <= 1 的边界情况的问题 2. 删除了有误导性的条件判断。事实上，被删除的表达式永远为真（searchChild !== undefined)。原作者想表达的意思可能是 this.queue[searchChild] !== undefined，而实际上，这个判断也是不必要的，这种情况会被后续的 this.compare(index, searchChild) > 0 判断排除。但鉴于本项目的教程性质，直接去除可能会导致语义不清，考虑酌情将原处替换为 this.queue[searchChild] !== undefined 或直接删除
Update 0347.前K个高频元素.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )