Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build order slightly #212

Closed
jonathanspw opened this issue Mar 5, 2024 · 1 comment · Fixed by AlmaLinux/albs-frontend#479, AlmaLinux/albs-node#113 or AlmaLinux/albs-web-server#873
Assignees

Comments

@jonathanspw
Copy link
Member

When doing parallel builds currently we have to wait on the first build (x86 generally) to finish before the other builds can start, so that they all use the same SRPM. This creates unnecessary delays which is particularly frustrating when doing builds by hand for testing, etc.

SRPM generation is very fast relative to full builds, so it would make the most sense to have a dedicated step for building the SRPM, then trigger all of the builds at once. The result should basically be that builds take half as long because you're not waiting on the first build to finish before running the rest, only the SRPM build.

Mentioned this briefly to @javihernandez in Brussels and I think he understands what I'm getting at here.

@javihernandez
Copy link
Member

Hey @jonathanspw, first, thanks for this suggestion.

We have talked about this and these are our thoughts.

This involves factoring the SRPM build out of the current build process and make it a separate first step, this is:

  1. try building the srpm
  2. if no srpm can be built - mark build as failed
  3. if we got an srpm - keep going with rpm building

It would involve some non-trivial refactoring of our current workflow, but we believe that this won't only be beneficial in building (or failing) speed, but also, it's a good opportunity for us to simplify the current logic around the srpm_built checks, that now can be go into a separate process_srpm method and process_rpms will become simpler.

It would also involve updating the UI to reflect the changes. Right now, we have this:

image

And when looking at build logs, we get this:

image

After the changes are made in backend, we'd need to:

  • Remove the SRPM build logs from current arch build logs view
  • Add a new src column alongside the rest of the arches, and upon clicking on it, it'll show the SRPM build logs

maccelf added a commit to AlmaLinux/albs-frontend that referenced this issue Jun 18, 2024
maccelf added a commit to AlmaLinux/albs-frontend that referenced this issue Jun 18, 2024
maccelf added a commit to AlmaLinux/albs-node that referenced this issue Jun 18, 2024
maccelf added a commit to AlmaLinux/albs-web-server that referenced this issue Jun 18, 2024
maccelf added a commit to AlmaLinux/albs-frontend that referenced this issue Jun 18, 2024
maccelf added a commit to AlmaLinux/albs-node that referenced this issue Jun 18, 2024
maccelf added a commit to AlmaLinux/albs-frontend that referenced this issue Jun 21, 2024
maccelf added a commit to AlmaLinux/albs-web-server that referenced this issue Jun 21, 2024
maccelf added a commit to AlmaLinux/albs-node that referenced this issue Jun 21, 2024
maccelf added a commit to AlmaLinux/albs-node that referenced this issue Jul 2, 2024
maccelf added a commit to AlmaLinux/albs-frontend that referenced this issue Jul 2, 2024
maccelf added a commit to AlmaLinux/albs-web-server that referenced this issue Jul 2, 2024
maccelf added a commit to AlmaLinux/albs-node that referenced this issue Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants