Change build order #113
Merged
Change build order #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Summary
Linter reportsThe reports are too big to be posted here. View full reports on the Job Summary page. |
Korulag
requested changes
Jun 18, 2024
Korulag
requested changes
Jun 18, 2024
Korulag
approved these changes
Jun 27, 2024
build_node/mock/mock_config.py
Outdated
| @@ -286,7 +286,7 @@ def get_default_legal_host_arches(target_arch): | |||
| return 'x86_64', | |||
| elif target_arch in ('i386', 'i586', 'i686'): | |||
| return 'i386', 'i586', 'i686', 'x86_64' | |||
| elif target_arch == 'noarch': | |||
| elif target_arch == 'noarch' or target_arch == 'src': | |||
There was a problem hiding this comment.
can't we do a target_arch in ('noarch', 'src') here?
soksanichenko
approved these changes
Jul 1, 2024
javihernandez
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: AlmaLinux/build-system#212