-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALBS-638: Added CycloneDX formatter #3
Conversation
Also: * Added a test script that uses these models * Added requirements.txt
Added a basic example implementation
Deleted previous content
Build creation time now it's added as a property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is due to cyclonedx-python-lib only supporting currently active Python releases.
def generate_package_sbom(self): | ||
# TODO: Figure out how to set the SBOM version, because | ||
# self._bom.version = self.input_data['version'] results | ||
# in adding 'ersion: 1' to the final SBOM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that here should be version: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, you're reading it correctly 😅. If you try setting the bom version manually, it ends up in a field called "ersion". I left the TODO item to address it later, when we decide how we're going to provide the ability to update already generated sboms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but as far I can remember, Eugene told about changing name for our generator, because sbom_generator is too generic
Yes, I wanted to dump the comments from Eugene into another ticket and then address them, mostly, because this PR is starting to include things out of scope - although nothing against including all them into it |
Updtaed related resources: README.md and setup.py
0d37c7e
to
0f82f45
Compare
I renamed the script into alma_sbom.py. If memory serves me well, the only remaining comment from Eugene is that we should merge the arguments type and format into one, so we enter |
No description provided.