12696 automatically add payment data type to applicationmetadata when adding payment task #12776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/process
standeren
force-pushed
the
12696-automatically-add-payment-data-type-to-applicationmetadata-when-adding-payment-task
branch
4 times, most recently
from
79cd8a0 to
b1fa767
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12776 +/- ##
==========================================
+ Coverage 90.24% 90.26% +0.02%
==========================================
Files 1318 1320 +2
Lines 18914 18953 +39
Branches 2310 2313 +3
==========================================
+ Hits 17068 17107 +39
Misses 1582 1582
Partials 264 264 ☔ View full report in Codecov by Sentry. |
standeren
force-pushed
the
12696-automatically-add-payment-data-type-to-applicationmetadata-when-adding-payment-task
branch
from
b1fa767 to
a7679f9
Compare
nkylstad
requested changes
May 8, 2024
frontend/packages/process-editor/src/bpmnProviders/SupportedPaletteProvider.js
Show resolved
Hide resolved
frontend/packages/process-editor/src/bpmnProviders/SupportedPaletteProvider.js
Outdated
Show resolved
Hide resolved
frontend/packages/process-editor/src/hooks/useBpmnEditor.test.tsx
Outdated
Show resolved
Hide resolved
standeren
force-pushed
the
12696-automatically-add-payment-data-type-to-applicationmetadata-when-adding-payment-task
branch
2 times, most recently
from
df4d27c to
02d8bcc
Compare
nkylstad
approved these changes
May 13, 2024
standeren
force-pushed
the
12696-automatically-add-payment-data-type-to-applicationmetadata-when-adding-payment-task
branch
from
02d8bcc to
4ce9dff
Compare
standeren
deleted the
12696-automatically-add-payment-data-type-to-applicationmetadata-when-adding-payment-task
branch
Jondyr
pushed a commit
that referenced
this pull request
Jun 10, 2024
… adding payment task (#12776) * Add/delete dataType when taskType is payment or signing * Support multiple data types for multiple payment or signing tasks * Fix PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add dataType to appmetadata when adding payment and signing tasks to bpmn process.
Use custom prefix id
paymentInformation-andsignatureInformation-and 4 characters random identifier as suffix.Remove same dataType when deleting using the same dataTypeId as identifier for backend.
Related Issue(s)
Verification