Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resourceadm: allow publishing resources and editing access lists in AT21 and AT24 #12781

Merged

Conversation

mgunnerud
Copy link
Contributor

Description

  • Add AT21 and AT24 to list of available environments for publish resource and edit access lists
  • Use helper function to display environments in import service from Altinn 2 modal, to hide AT environments from users outside ttd organization.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@mgunnerud mgunnerud linked an issue May 7, 2024 that may be closed by this pull request
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. skip-releasenotes Issues that do not make sense to list in our release notes labels May 7, 2024
@mgunnerud mgunnerud requested a review from a user May 7, 2024 12:12
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (da69059) to head (d673225).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12781   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files        1308     1308           
  Lines       18760    18760           
  Branches     2281     2281           
=======================================
  Hits        16921    16921           
  Misses       1579     1579           
  Partials      260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkylstad nkylstad added the area/resource-adm Issues related to resource administration label May 15, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@mgunnerud mgunnerud merged commit 240e2c7 into main May 15, 2024
10 checks passed
@mgunnerud mgunnerud deleted the 12772-resourceadm-allow-publishing-resources-to-at21-and-at24 branch May 15, 2024 10:33
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
…T21 and AT24 (#12781)

* add teams for publish resource and edit access lists for AT21 and AT24

* allow publish resource and edit access lists in AT21 and AT24

* show labels for test environments in import from Altinn 2 modal

* only allow import Altinn 2 service from AT environments if user belongs to ttd organization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/resource-adm Issues related to resource administration skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resourceadm: allow publishing resources to AT21 and AT24
2 participants