Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eclipse project #20

Merged

Conversation

ElectricRCAircraftGuy
Copy link
Collaborator

This PR adds an Eclipse project so that the entire Arduino source code, including the Arduino core, can easily be browsed--same as in a professional project.

@ElectricRCAircraftGuy
Copy link
Collaborator Author

ElectricRCAircraftGuy commented Apr 12, 2020

NOTE THAT THIS PR ONLY EDITS LIKE 9 FILES, DESPITE IT SAYING IT EDITS LIKE 224 FILES. You must accept PR #18 first in order for the comparison to look correct, so please merge PR #18 and then look at this PR.

@nimrod46
Copy link
Member

@ElectricRCAircraftGuy Thanks so much for your contributions, I will merge this PR once the conflict is solved.

@ElectricRCAircraftGuy
Copy link
Collaborator Author

Conflicts resolved; ready for review. See "AmboVent/3-Software/Arduino/readme.md" for a description of the new files, and see "AmboVent/3-Software/Arduino/arduino_core/readme.md" for a description of how to link in the Arduino core for browsing in Eclipse.

@ElectricRCAircraftGuy
Copy link
Collaborator Author

I've rebased onto your latest master and force pushed to resolve conflicts. It is ready to merge again.

@ElectricRCAircraftGuy
Copy link
Collaborator Author

ElectricRCAircraftGuy commented Apr 12, 2020

I also checked to make sure it still builds, and it does. Dynamic memory significantly improved! I see a few progmem usages in there. That's good.

Sketch uses 18412 bytes (59%) of program storage space. Maximum is 30720 bytes.
Global variables use 1046 bytes (51%) of dynamic memory, leaving 1002 bytes for local variables. Maximum is 2048 bytes.

@nimrod46 nimrod46 merged commit 8905b7b into AmboVent-1690-108:master Apr 12, 2020
@ElectricRCAircraftGuy ElectricRCAircraftGuy deleted the add_eclipse_project branch April 13, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants