Tns24 #63
Merged
Tns24 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated TNS submit methods. New plot methods, merged from nuztf. Updated poetry files. remove unimplemented method ruff noqa flags added chore: ruff cleanup Remove old TNS units. clean test After removing out of day tests, the github ruff test fails (works locally). Also remove obsolute TNS submit routines. mypy edits chore: add ruff to pre-commit config ruff check ...and correcting ruff changes so mypy still happy. ...and correcting ruff changes so mypy still happy. type support for Pillow Plot options for Colibri. Pull wrt magdifflim as criteria. Fixed bug in TNS resonse query.
|
Further changes were made to the TNSClient to make this work also with the TNS functions to submit reports and review their submit status |
jvansanten
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Overall this looks good, but there are a few things I don't understand:
- What do the new classes that query cutouts from the archive and reports from the TNS mirror do that is not possible with the existing complement units?
- Where does tabulation get used in PlotTransientLightCurves?
- Does PlotTransientLightCurves actually need a scratch directory, or is this just a caching optimization?
jvansanten
approved these changes
May 14, 2024
jvansanten
added a commit
that referenced
this pull request
May 23, 2024
* add more info from t2 eval Updated TNS submit methods. New plot methods, merged from nuztf. Updated poetry files. remove unimplemented method ruff noqa flags added chore: ruff cleanup Remove old TNS units. clean test After removing out of day tests, the github ruff test fails (works locally). Also remove obsolute TNS submit routines. mypy edits chore: add ruff to pre-commit config ruff check ...and correcting ruff changes so mypy still happy. ...and correcting ruff changes so mypy still happy. type support for Pillow Plot options for Colibri. Pull wrt magdifflim as criteria. Fixed bug in TNS resonse query. * Allow digest redshift methods to be inherited. * Activate TNS submission and reply reading. * added T2KilonovaStats evaluation * Filter for looking for stellar flares. * Base unit for lightcurve fitters. * Two bugs caused by potentially empty catalog entries. * Units for demo linear fit and search for stellar outburts. * Updates to new API for TNS and AColibri uploads. * Remove debug prints. * Format updates. * Consistant unit naming and separated base and demo classes. * rm old names. * Ensure that a NamedSecret for Slack publishing is not required. * Shift dependence from TNSMirrorSearcher to complements through TNSNames. * PlotTransientLightcurves now works with T3 complement cutouts. * SubmitTNS using complemented TNS ids when possibl. * Ripped out TNS and cutout duplicated methods. * refine first-sentence detection --------- Co-authored-by: andimatter <hermydrea@web.de> Co-authored-by: Jakob van Santen <jvansanten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Ampel-HU-astro which incorporates plot routines from nu-ztf as well as updated routines from submitting transients to TNS.
Some things for potential discussion:
PlotTransientLightcurvesinherits from AbsTabulatedT2Unit. Based on names, this is inconsistent, but works quite well since the same methods were needed here. Leave this as it is, rename the tabulator units or create a new set of units for T3?