Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tns24 #63

Merged
merged 27 commits into from
May 23, 2024
Merged

Tns24 #63

merged 27 commits into from
May 23, 2024

Conversation

wombaugh
Copy link
Contributor

@wombaugh wombaugh commented Mar 5, 2024

Updates to Ampel-HU-astro which incorporates plot routines from nu-ztf as well as updated routines from submitting transients to TNS.

Some things for potential discussion:

  • The T3 PlotTransientLightcurves inherits from AbsTabulatedT2Unit. Based on names, this is inconsistent, but works quite well since the same methods were needed here. Leave this as it is, rename the tabulator units or create a new set of units for T3?
  • There is an abstract, TNSMirrorSearcher, which does the matching for an individual object with the TNS Mirror DB. Was it something like this you had in mind?
  • Two new methods were added to the TNSClient. Do they fulfill the asyncio requirements? They seem to work...
  • PlotTransientLightcurves downloads thumbnails which are saved to scratch dir. This is not set as a base string in the config. Should a more elegant scratch dir be used?

Updated TNS submit methods.

New plot methods, merged from nuztf.

Updated poetry files.

remove unimplemented method

ruff noqa flags added

chore: ruff cleanup

Remove old TNS units.

clean test

After removing out of day tests, the github ruff test fails (works locally).

Also remove obsolute TNS submit routines.

mypy edits

chore: add ruff to pre-commit config

ruff check

...and correcting ruff changes so mypy still happy.

...and correcting ruff changes so mypy still happy.

type support for Pillow

Plot options for Colibri.

Pull wrt magdifflim as criteria.

Fixed bug in TNS resonse query.
@wombaugh
Copy link
Contributor Author

Further changes were made to the TNSClient to make this work also with the TNS functions to submit reports and review their submit status

Copy link
Contributor

@jvansanten jvansanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, but there are a few things I don't understand:

  • What do the new classes that query cutouts from the archive and reports from the TNS mirror do that is not possible with the existing complement units?
  • Where does tabulation get used in PlotTransientLightCurves?
  • Does PlotTransientLightCurves actually need a scratch directory, or is this just a caching optimization?

ampel/contrib/hu/t0/StellarFilter.py Outdated Show resolved Hide resolved
ampel/contrib/hu/t2/T2DigestRedshifts.py Show resolved Hide resolved
ampel/contrib/hu/t2/T2LineFit.py Outdated Show resolved Hide resolved
ampel/contrib/hu/t2/T2RunLightcurveFitter.py Outdated Show resolved Hide resolved
ampel/contrib/hu/util/TNSMirrorSearcher.py Outdated Show resolved Hide resolved
ampel/contrib/hu/t3/SubmitTNS.py Outdated Show resolved Hide resolved
ampel/contrib/hu/t3/PlotTransientLightcurves.py Outdated Show resolved Hide resolved
@jvansanten jvansanten merged commit 7aebc5c into main May 23, 2024
6 checks passed
@jvansanten jvansanten deleted the tns24 branch May 23, 2024 14:22
jvansanten added a commit that referenced this pull request May 23, 2024
* add more info from t2 eval

Updated TNS submit methods.

New plot methods, merged from nuztf.

Updated poetry files.

remove unimplemented method

ruff noqa flags added

chore: ruff cleanup

Remove old TNS units.

clean test

After removing out of day tests, the github ruff test fails (works locally).

Also remove obsolute TNS submit routines.

mypy edits

chore: add ruff to pre-commit config

ruff check

...and correcting ruff changes so mypy still happy.

...and correcting ruff changes so mypy still happy.

type support for Pillow

Plot options for Colibri.

Pull wrt magdifflim as criteria.

Fixed bug in TNS resonse query.

* Allow digest redshift methods to be inherited.

* Activate TNS submission and reply reading.

* added T2KilonovaStats evaluation

* Filter for looking for stellar flares.

* Base unit for lightcurve fitters.

* Two bugs caused by potentially empty catalog entries.

* Units for demo linear fit and search for stellar outburts.

* Updates to new API for TNS and AColibri uploads.

* Remove debug prints.

* Format updates.

* Consistant unit naming and separated base and demo classes.

* rm old names.

* Ensure that a NamedSecret for Slack publishing is not required.

* Shift dependence from TNSMirrorSearcher to complements through TNSNames.

* PlotTransientLightcurves now works with T3 complement cutouts.

* SubmitTNS using complemented TNS ids when possibl.

* Ripped out TNS and cutout duplicated methods.

* refine first-sentence detection

---------

Co-authored-by: andimatter <hermydrea@web.de>
Co-authored-by: Jakob van Santen <jvansanten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants