Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/enable pdb qa #492

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Hotfix/enable pdb qa #492

merged 2 commits into from
Jun 12, 2024

Conversation

orzut
Copy link
Collaborator

@orzut orzut commented Jun 12, 2024

  • Enabling Phenotype Database tool in QA
  • Making categories fetch case insensitive

@orzut orzut requested a review from r-vieira June 12, 2024 16:09
Copy link
Collaborator

@r-vieira r-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! See inline comments

@@ -62,7 +62,7 @@ def get_tags(self):
If no tag set defined, returns None.
'''
if self.tags:
return { tg.strip() for tg in self.tags.split(',') }
return { tg.strip().lower() for tg in self.tags.split(',') }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor detail -- do we need a space after the comma, eg: , ?

@r-vieira r-vieira merged commit 6202a18 into development Jun 12, 2024
3 checks passed
@r-vieira r-vieira deleted the hotfix/enable-PDB-qa branch June 12, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants