Support for InputField (used for new "Enjoy Life Forever!" brochure) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasSko
force-pushed
the
input_field
branch
8 times, most recently
from
8a13f31
to
725f620
Compare
AndreasSko
commented
Mar 21, 2021
AndreasSko
force-pushed
the
input_field
branch
2 times, most recently
from
aaf1b47
to
136ea63
Compare
AndreasSko
force-pushed
the
input_field
branch
2 times, most recently
from
57239d7
to
3dff0b1
Compare
InputField is used for interactive publications like the new "Enjoy Life Forever!" book. It can contain arbitrary text values.
The table `InputField` does not have an ID column, so we can't determine the slice capacity using that. As we at the same time don't need to have a proper order anymore, we can just use the number of entries.
Some fields of a Model may not be represented in the actual database table. Adding the `ignore:"true"` tag will ignore those, so it is not tried to import/export them.
This adds support to import the `InputField` table. Also updated the tests to incorporate this change.
Sorting slices of Models by uniqueKey is something that is also useful in other packages.
This adds the capability to the CMD and Gomobile to merge InputFields.
Somehow `tj/assert` was used for some tests. Switching back to use `stretchr/testify` in testing.
AndreasSko
added a commit
to AndreasSko/ios-jwlm
that referenced
this pull request
Mar 22, 2021
This adds support for merging InputFields. See AndreasSko/go-jwlm#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Enjoy Life Forever! brochure is the first one to use the
InputFieldtable. It uses it to store the progress and notes users are saving.Right now, JWLM will fail to import backups containing entries in InputField. This PR adds support for it.
Other changes:
stretchr/testifyand removetj/assert(was added by mistake)