Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support for InputField (used for new "Enjoy Life Forever!" brochure) #30

Merged
merged 9 commits into from
Mar 27, 2021

Conversation

AndreasSko
Copy link
Owner

@AndreasSko AndreasSko commented Mar 22, 2021

This adds support for merging InputFields. Also see AndreasSko/go-jwlm#52

Other changes

  • Improve BackupView for smaller screens: The font is now a bit smaller, so everything fits into the card even on an iPhone SE
  • Added a legend for the Conflict Autoresolution symbols, so users can more easily identify what which symbol means what
  • Cleaned up the code a bit (though there still a lot of room for improvement..)

This adds support for merging InputFields.
See AndreasSko/go-jwlm#52
This adds support so JWLM is able to decode
InputFields.
Instead of setting frame and padding for each
case separately, we can set it directly to the
VStack.
Merge InputFields and show possible conflicts.
@AndreasSko AndreasSko force-pushed the input_field branch 2 times, most recently from 3596426 to 422af0f Compare March 26, 2021 19:06
To keep the name short enough to fit in the
view, I'm simply going to call it `Inputs`.
This adds the ability for the HelpView to include
more views. This will be neat for the next commit
so we can include a legend for the various
merge settings.
This adds inputFields to the mergeSettings.

It also adds a legend for users to more easily
identify the different symbols and what they
mean.
By checking the absolute screen width, we can
shrink the font a bit more if the screen is smaller
than 380.
@AndreasSko AndreasSko marked this pull request as ready for review March 27, 2021 16:27
@AndreasSko AndreasSko merged commit a452a35 into master Mar 27, 2021
@AndreasSko AndreasSko deleted the input_field branch March 27, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant