Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need detailed documentation to persuade others. #10

Closed
AndrewDongminYoo opened this issue Mar 14, 2023 · 1 comment
Closed

We need detailed documentation to persuade others. #10

AndrewDongminYoo opened this issue Mar 14, 2023 · 1 comment
Assignees
@AndrewDongminYoo
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@AndrewDongminYoo
Copy link
Owner

Expected Behavior

  • As the new architecture's reactive native development method has clear advantages, it is also important to write meticulous documents to persuade established developers.

Actual Behavior

  • The NPM package installation script and code used in actual apps account for most of the documented content, so there is no real reference, and the corresponding existing development method is not convincing even though the risk of applying the new architecture is applied.

Steps to Reproduce the Problem

  1. yarn add @dongminyu/react-native-step-counter
  2. RCT_NEW_ARCH_ENABLED=1 \ cd ios && pod install
  3. yarn run-*android/ios*

Specifications

first, you should check your react-native-step-counter version and write it down.

  • @dongminyu/react-native-step-counter version: 0.1.9

second, you should check your react-native version and write it down. you should use this command. npx react-native info
and then, it would be better if you paste the output of this command.

  • INFO OUTPUT
System:
    OS: macOS 13.2.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 2.67 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.14.1 - ~/.nvm/versions/node/v18.14.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.14.1/bin/yarn
    npm: 9.5.0 - ~/.nvm/versions/node/v18.14.1/bin/npm
    Watchman: 2023.03.13.00 - /opt/homebrew/bin/watchman
  Managers:
    Ruby: ruby 2.7.6p219 (2022-04-12) [arm64-darwin22]
    CocoaPods: Not Found
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
    Android SDK:
      Android NDK: 22.1.7171670
  IDEs:
    Android Studio: Electric Eel 2022.1.1 Patch 1 Electric Eel 2022.1.1 Patch 1
    Xcode: 14.2/14C18 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.16 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0 
    react-native: 0.71.4 => 0.71.4 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found
@AndrewDongminYoo AndrewDongminYoo added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 14, 2023
@AndrewDongminYoo AndrewDongminYoo self-assigned this Mar 14, 2023
AndrewDongminYoo added a commit that referenced this issue Mar 14, 2023
@AndrewDongminYoo
docs(react): 📝 written a detailed document on importing turbo-module
b9b7925 
We have written a detailed document on importing turbo-module-built libraries into existing legacy reactive applications. The *.config.js configuration files that were all merged into package.json were separated into separate files.

#10
AndrewDongminYoo added a commit that referenced this issue Mar 14, 2023
@AndrewDongminYoo
docs(react): 📝 wrote a detailed document on importing turbo-module
8d8800a 
We have written a detailed document on
importing turbo-module-built libraries
into existing legacy reactive applications.
The *.config.js configuration files that
were all merged into package.json were
separated into separate files.

We need detailed documentation to persuade others. #10
@AndrewDongminYoo
Copy link
Owner Author

  • iOS: ⬆️ all .m files in StepCounter folder should be renamed to .mm (983be85), closes #1
  • react: ✏️ @yusungLEVIT reported typo fixed (09a3056), closes #8
  • react: 📝 wrote a detailed document on importing turbo-module (8d8800a), closes #10

Notion – 프로젝트 리포트

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewDongminYoo AndrewDongminYoo

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
dongminyu's first npm library development
Status: Done: 완료
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndrewDongminYoo