Skip to content

Conversation

mpekalski
Copy link
Contributor

When property of layout textAllCaps was set to true, the string got fit to view before the caps were applied. This fix checks if the property is set, makes the string upper case if true, and then performs the fit.

when property of layout textAllCaps was set to true, the string got fit to view before the caps were applied. This fix checks if the property is set, makes the string upper case if true, and then performs the fit.
@mpekalski mpekalski mentioned this pull request Mar 5, 2016
@mpekalski mpekalski closed this Mar 6, 2016
@mpekalski mpekalski reopened this Mar 6, 2016
@mpekalski
Copy link
Contributor Author

Modified the solution as discussed in the comments.

@AndroidDeveloperLB
Copy link
Owner

I think you should also call the resize function inside setAllCaps
On Mar 6, 2016 21:44, "Marcin Pękalski" notifications@github.com wrote:

Modified the solution as discussed in the comments.


Reply to this email directly or view it on GitHub
#26 (comment)
.

@mpekalski
Copy link
Contributor Author

But I removed setAllCaps and _allCaps, leaving only solution proposed by yourself in the commends under the issue.

@AndroidDeveloperLB
Copy link
Owner

I meant something like this:

@Override
public void setAllCaps(boolean allCaps) {
    super.setAllCaps(allCaps);
    adjustTextSize();
}

@mpekalski
Copy link
Contributor Author

Done.

AndroidDeveloperLB added a commit that referenced this pull request Mar 6, 2016
@AndroidDeveloperLB AndroidDeveloperLB merged commit 42ca158 into AndroidDeveloperLB:master Mar 6, 2016
@AndroidDeveloperLB
Copy link
Owner

nice. thank you.

@mpekalski
Copy link
Contributor Author

I thank you too.

@AndroidDeveloperLB
Copy link
Owner

If you know how to fix the other issues, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants