Rewrite the crate #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed By: Anhad Singh
* Add documentation to the StivaleFramebufferTag * Add documentation to the StivaleTerminalTag * Return a function instead for the term_write function. Signed By: Anhad Singh
48cf
commented
Jun 28, 2021
* Fix typo in v2/ * Add module documentation to v2/mod.rs * Fix terminal tag doc test Signed By: Anhad Singh
* Add the RSDP ACPI tag Signed By: Anhad Singh
* Add the memory map tag and its child structures * Add documentation to those structures Signed By: Anhad Singh
* Add more tags * Add them in the main stivale structure Signed By: Anhad Singh
Release ChecklistStivale v2Tags Checklist
Headers Checklist
|
* Finish adding and documenting all of the header types for stivale2 Signed By: Anhad Singh
* Finish adding all of the stivale2 tags and I still have to add them in the main stivale structure Signed By: Anhad Singh
* Added some fixes and final methods for this pull request and is ready to merge! Signed By: Anhad Singh
Andy-Python-Programmer
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the crate into an easier to work with interface. I already have added the stivale2 structure and ability to retrieve tags inside of it by their ID. I also added few helper methods to retrieve a specific tag with correct type. I still need to add all the missing tags that are specified in the stivale2 specification and document the code, since as of now it's left with no comments whatsoever. There is also the stivale2 header structure and few header tags that let you specify a simple terminal output so you can verify everything is working correctly.