HtmlParser.Parse throws InvalidOperationException #735

Metalnem · 2018-12-26T07:55:38Z

HtmlParser.Parse throws InvalidOperationException on some HTML inputs. Here's the full program to reproduce one such case:

using AngleSharp.Parser.Html;

namespace AngleSharp.Run
{
  public class Program
  {
    public static void Main(string[] args)
    {
      string html = @"<svg><!DOCTYPE html><<template>html><desc><template>><p>p</p></body></html>";
      new HtmlParser().Parse(html);
    }
  }
}

And here is the stack trace:

An unhandled exception of type 'System.InvalidOperationException' occurred in System.Collections.dll: 'Stack empty.'
   at System.Collections.Generic.Stack`1.ThrowForEmptyStack()
   at System.Collections.Generic.Stack`1.Peek()
   at AngleSharp.Parser.Html.HtmlParserExtensions.SelectMode(Element element, Boolean isLast, Stack`1 templateModes)
   at AngleSharp.Parser.Html.HtmlDomBuilder.Reset()
   at AngleSharp.Parser.Html.HtmlDomBuilder.InTemplate(HtmlToken token)
   at AngleSharp.Parser.Html.HtmlDomBuilder.InBody(HtmlToken token)
   at AngleSharp.Parser.Html.HtmlDomBuilder.Parse(HtmlParserOptions options)
   at AngleSharp.Run.Program.Main(String[] args) in

Found via SharpFuzz.

The text was updated successfully, but these errors were encountered:

FlorianRappl · 2018-12-26T10:44:44Z

Hi @Metalnem please report all found cases. It is sufficient to report the HTML source, e.g.,

<svg><!DOCTYPE html><<template>html><desc><template>><p>p</p></body></html>

Thanks for the report!

Metalnem · 2018-12-26T10:48:32Z

They are all very similar, and will result in the same exception. I've found five different ones so far:

<svg><!DOCTYPE html><<template>html><desc><template>><p>p</p></body></html>

<svg><!DOCTYPE html><html><template><desc><template>><p>p</p></body></html>

<svg><!DOCTYPE html><<<template>tml><desc><template>><p>p</p></body></html>

<svg><!DOCTYPE html><<frameset>h<template>tml><desc><template>><p>p</p></body></html>

<svg><!DOCTYPE html><template>>html><desc><template>><p>p</p></body></html><pre>

FlorianRappl added this to the v0.10 milestone Dec 26, 2018

FlorianRappl added bug parser labels Dec 26, 2018

FlorianRappl added a commit that referenced this issue Dec 29, 2018

Added tests for #735

153d13d

FlorianRappl added a commit that referenced this issue Dec 29, 2018

Fixed mode selection #735

29aca0f

FlorianRappl closed this as completed Dec 29, 2018

HtmlParser.Parse throws InvalidOperationException #735

HtmlParser.Parse throws InvalidOperationException #735

Metalnem commented Dec 26, 2018

FlorianRappl commented Dec 26, 2018

Metalnem commented Dec 26, 2018

HtmlParser.Parse throws InvalidOperationException #735

HtmlParser.Parse throws InvalidOperationException #735

Comments

Metalnem commented Dec 26, 2018

FlorianRappl commented Dec 26, 2018

Metalnem commented Dec 26, 2018