Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to build against usd-0.19.5 #150

Closed
wants to merge 2 commits into from
Closed

Fixes to build against usd-0.19.5 #150

wants to merge 2 commits into from

Conversation

pmolodo
Copy link
Contributor

@pmolodo pmolodo commented Apr 9, 2019

Description (this won't be part of the changelog)

  • usd-0.19.05 now needs GlfContextCaps::InitInstance() called anywhere GlfGlewInit() is

Checklist (Please do not remove this line)

  • Make sure the Title and Description of the PR make sense and provide sufficient context for your work
  • Do any added files have the correct AL Apache Licence Header?
  • Are there Doxygen comments in the headers?
  • Are any new features, behaviour changes documented in the .md format documentation?
  • Have you added, updated tests to cover new features and behaviour changes?
  • Have you filled out at least one changelog entry?
  • Is the branch's history clean? (only relevant commits)

usd-0.19.05 now needs GlfContextCaps::InitInstance() called anywhere …
751885d 
…GlfGlewInit() is

as of this commit in USD:
cb575058ae495c9bf5afe1863c39df78921ea499
[Glf +] Fix for crash initializing GlfContextCaps.
@pmolodo pmolodo mentioned this pull request Apr 9, 2019
Closed
7 tasks
robthebloke
robthebloke approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@robthebloke robthebloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@murphyeoin murphyeoin added the ToTest need to run tests label May 2, 2019
make sure gl context exists before calling GlfContextCaps::InitInstan…
e98f360 
…ce()

otherwise, was getting errors when loading AL_USDMaya from a non-gui maya
@pmolodo
Copy link
Contributor Author

pmolodo commented Jun 12, 2019

Was seeing an error message printed to console when loading in non-gui maya - fixed by a check against the GL context

@pmolodo pmolodo mentioned this pull request Jun 27, 2019
Closed
7 tasks
@pmolodo pmolodo closed this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robthebloke robthebloke robthebloke approved these changes

Assignees
No one assigned
Labels
ToTest need to run tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmolodo @robthebloke @murphyeoin