Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round M73 P to 3 decimal places #29

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

garethky
Copy link
Contributor

@garethky garethky commented Sep 1, 2022

Makes the P parameter a float to match klipper's support for floats

Makes the P parameter a float to match klipper's support for floats
@garethky garethky mentioned this pull request Sep 1, 2022
@garethky
Copy link
Contributor Author

garethky commented Sep 1, 2022

I couldn't get the build to workflow to complete in my fork. Looks to be something other than a coding error.

@dalegaard dalegaard marked this pull request as ready for review September 1, 2022 09:27
@dalegaard dalegaard merged commit a7d4407 into Annex-Engineering:master Sep 1, 2022
@dalegaard
Copy link
Collaborator

Hi @garethky

The build thing is because of the versioning from git tag. Since your repo has no tags, I think that's causing it to fail. I'll look into something for that later on.

As to code, obviously looks fine. I've run cargo fmt, so merged :-)

Best regards,
Lasse

@garethky
Copy link
Contributor Author

garethky commented Sep 1, 2022

@dalegaard thanks! How can I get an artifact from the build to test it with?

@dalegaard
Copy link
Collaborator

Hi @garethky

I've released 2.0.6 with this change and also fixed the build.rs script to no longer fail outside git repos. You can either update your own branch and trigger a build, you can use the pre-built artifacts, or you can build locally :-)

Best regards,
Lasse

@garethky
Copy link
Contributor Author

garethky commented Sep 2, 2022

Thank you! I grabbed the binary and see the expected output:

M73 P2.838 R353
...
M73 P3.026 R353

I need to get some time over the long weekend to compare the behavior of KlipperScreen and Fluidd before and after the patch, maybe grab some video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants