Skip to content

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jan 12, 2021

Update README

  • TOC-Figure
  • Correct False-Default in args
  • Setup for release
  • Update the introduction of README.md

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 12, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 5.38 ⭐ 5.38 ⭐ 0.00
Method Length 65.91 🙂 65.91 🙂 0.00
Working memory 8.21 🙂 8.21 🙂 0.00
Quality 64.82% 🙂 64.82% 🙂 0.00%
Other metrics Before After Change
Lines 338 338 0
Changed files Quality Before Quality After Quality Change
bashplot/init.py 100.00% ⭐ 100.00% ⭐ 0.00%
bashplot/bashplot.py 64.38% 🙂 64.38% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bashplot/bashplot.py plot 12 🙂 250 ⛔ 10 😞 43.77% 😞 Try splitting into smaller methods. Extract out complex expressions
bashplot/bashplot.py get_args 3 ⭐ 194 😞 10 😞 55.88% 🙂 Try splitting into smaller methods. Extract out complex expressions
bashplot/bashplot.py load_data 0 ⭐ 39 ⭐ 10 😞 78.27% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@Anselmoo Anselmoo merged commit 3dd2fbd into master Jan 12, 2021
@Anselmoo Anselmoo deleted the UpdateREADME branch January 12, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant