-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ✨ Update devcontainer.json with new features #1237
Conversation
- Update `devcontainer.json` with new features to switch latest or specific version - Add poetry shell command to `setup.sh`
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
"ghcr.io/devcontainers-contrib/features/prettier:1": { | ||
"version": "latest" | ||
}, | ||
"ghcr.io/devcontainers/features/docker-in-docker": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (code_clarification): Duplicate feature keys for Docker in Dev Container configuration.
The configuration includes both 'docker-in-docker' and 'docker-in-docker:2'. Ensure this is intentional and not a duplication error.
"version": "20.10", | ||
"dockerDashComposeVersion": "v2" | ||
}, | ||
"ghcr.io/devcontainers/features/github-cli:1": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code_refinement): Using 'latest' version for GitHub CLI.
Specifying 'latest' for the GitHub CLI version might lead to unexpected changes. Consider pinning a specific version for more predictable builds.
"ghcr.io/devcontainers/features/github-cli:1": { | |
"ghcr.io/devcontainers/features/github-cli:1": { | |
"installDirectlyFromGitHubRelease": true, | |
"version": "2.0.0" | |
}, |
@@ -2,3 +2,4 @@ python -m pip install --upgrade pip | |||
python -m pip install poetry | |||
poetry config virtualenvs.in-project true | |||
python -m poetry install --with dev,docs --all-extras | |||
poetry shell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (code_clarification): Consider the necessity of 'poetry shell' in setup script.
Activating a shell might not be effective in a script. If the intention is to prepare the environment, ensure this command's effects persist as expected.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4467 4467
=========================================
Hits 4467 4467
Flags with carried forward coverage won't be shown. Click here to find out more. |
devcontainer.json
with new features to switch latest or specific versionsetup.sh
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?