Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: unifying set_finalizers interface with Leap and BIOS Contract #257

Closed
Tracked by #245
linh2931 opened this issue Dec 15, 2023 · 0 comments · Fixed by #259
Closed
Tracked by #245

IF: unifying set_finalizers interface with Leap and BIOS Contract #257

linh2931 opened this issue Dec 15, 2023 · 0 comments · Fixed by #259
Assignees
@heifner
Labels
👍 lgtm
Milestone
IF

Comments

@linh2931
Copy link
Member

linh2931 commented Dec 15, 2023 •
edited
Loading

Currently CDT and Leap use abi_finalizer_policy while BIOS contract uses finalizer_policy. Some field names and types are also different. Unify them to reduce future confusion.

Leap AntelopeIO/leap#1992
Reference-Contract AntelopeIO/reference-contracts#34
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Dec 15, 2023
This was referenced Dec 15, 2023
Closed
Closed
Merged
@arhag arhag mentioned this issue Dec 15, 2023
Closed
@arhag arhag added 👍 lgtm and removed triage labels Dec 15, 2023
@heifner heifner self-assigned this Dec 19, 2023
@heifner heifner moved this from Todo to In Progress in Team Backlog Dec 19, 2023
heifner added a commit that referenced this issue Dec 19, 2023
@heifner
GH-257 Rename set_finalizers types to match eosio.bios and leap names
d572004
@heifner heifner mentioned this issue Dec 19, 2023
Merged
@heifner heifner linked a pull request Dec 19, 2023 that will close this issue
IF: Rename set_finalizers types to match eosio.bios and leap names #259
Merged
heifner added a commit that referenced this issue Dec 19, 2023
@heifner
GH-257 Use public_key instead of public_key_g1. Update tests.
da082d4
heifner added a commit that referenced this issue Dec 19, 2023
@heifner
GH-257 Update with valid public key
e87d621
heifner added a commit that referenced this issue Dec 20, 2023
@heifner
Merge pull request #259 from AntelopeIO/GH-257-set-finalizers-types-r…
b1eacc8 
…ename

IF: Rename set_finalizers types to match `eosio.bios` and `leap` names
@heifner heifner closed this as completed Dec 20, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Dec 20, 2023
@arhag arhag added this to the IF milestone Dec 20, 2023
@arhag arhag mentioned this issue Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
IF
Development

Successfully merging a pull request may close this issue.

IF: Rename set_finalizers types to match eosio.bios and leap names AntelopeIO/cdt
4 participants
@heifner @arhag @linh2931 @enf-ci-bot