Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: unifying set_finalizers interface with CDT and BIOS Contract #1992

Closed
Tracked by #2110
linh2931 opened this issue Dec 15, 2023 · 0 comments · Fixed by #2004
Closed
Tracked by #2110

IF: unifying set_finalizers interface with CDT and BIOS Contract #1992

linh2931 opened this issue Dec 15, 2023 · 0 comments · Fixed by #2004
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Leap v6.0.0-rc1

Comments

@linh2931
Copy link
Member

linh2931 commented Dec 15, 2023 •
edited
Loading

Currently CDT and Leap use abi_finalizer_policy while BIOS contract uses finalizer_policy. Some field names and types are also different. Unify them to reduce future confusion.

Error messages in BIOS contract in Leap libtester are not consistent with BIOS contract in Reference-Contracts. Should be kept consistent.

CDT AntelopeIO/cdt#257
Reference-Contract AntelopeIO/reference-contracts#34
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Dec 15, 2023
This was referenced Dec 15, 2023
Closed
Closed
@arhag arhag mentioned this issue Dec 15, 2023
Closed
@arhag arhag added 👍 lgtm and removed triage labels Dec 15, 2023
@heifner heifner self-assigned this Dec 19, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Dec 19, 2023
@heifner heifner moved this from Todo to In Progress in Team Backlog Dec 19, 2023
heifner added a commit that referenced this issue Dec 19, 2023
@heifner
GH-1992 Use type names that match eosio.bios and CDT
7230452
@heifner heifner mentioned this issue Dec 19, 2023
Merged
@heifner heifner linked a pull request Dec 19, 2023 that will close this issue
IF: Use set_finalizer type names that match eosio.bios and CDT #2004
Merged
heifner added a commit that referenced this issue Dec 20, 2023
@heifner
Merge pull request #2004 from AntelopeIO/GH-1992-set-finalizer-types
a6a88ba 
IF: Use `set_finalizer` type names that match `eosio.bios` and CDT
@heifner heifner closed this as completed Dec 20, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Dec 20, 2023
@arhag arhag mentioned this issue Jan 19, 2024
Closed
@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap v6.0.0-rc1 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

Successfully merging a pull request may close this issue.

IF: Use set_finalizer type names that match eosio.bios and CDT AntelopeIO/leap
6 participants
@heifner @arhag @linh2931 @enf-ci-bot @BenjaminGormanPMP and others