Vectorclock abstraction #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewriting the meta data sender module abstract away from dicts
…/antidote into vectorclock_abstraction
peterzeller
reviewed
Jun 11, 2019
| end, ok, SS). | ||
| PrintFun = fun(DcId, Time) -> | ||
| logger:debug("~w staleness: ~w ms ~n", [DcId, (Now-Time)/1000]) end, | ||
| _ = vectorclock:map(PrintFun, SS), |
There was a problem hiding this comment.
Should we add a vectorclock:foreach function?
|
|
||
| -module(stable_time_functions). |
There was a problem hiding this comment.
Maybe add a behavior since these functions are used as callbacks?
There was a problem hiding this comment.
Let's add it once we have more than one instantiation.
Co-Authored-By: Peter Zeller <p_zeller@cs.uni-kl.de>
Co-Authored-By: Peter Zeller <p_zeller@cs.uni-kl.de>
…/antidote into vectorclock_abstraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactoring of meta_data_sender and related modules to use maps instead of dicts.
Further corrections of the unit tests and simplifications and cleaning up of code.
Hint: Vectorclock dependencies must be adapted still to new vectorclock version with maps.