fix Snapper id too long #36 #37
Conversation
fix Snapper id too long #36
41_snapshots-btrfs
Outdated
| @@ -293,7 +293,7 @@ snapshot_list() | |||
| for id in "${ids[@]}"; do | |||
| for j in "${!snapper_ids[@]}"; do | |||
| local snapper_id="${snapper_ids[$j]//[[:space:]]/}" | |||
| if [[ "$snapper_id" -eq "$id" ]]; then | |||
| if [[ "${snapper_id#0}" -eq "${id#0}" ]]; then | |||
There was a problem hiding this comment.
This isn't very nice, would string comparison work? if [[ "$snapper_id" == "$id" ]]
UPDATE: just tested, the == works just as good for snapper, so it won't break anything.
There was a problem hiding this comment.
it's just a quick fix
it is necessary to improve the recognition of snapshots created by snapper, and those made manually.
I didn't have time to look at your code in detail to do a more mature fix.
the error occurs when a snapshot contains a 0 at the beginning of its name
because you get your id out of a brutal hand.
this part of the code is not robust enough.
I was able to reproduce the error easily by setting up snapper
but still having my snapshots made manually.
for example:
btrfs sub list -sa /
ID 276 gen 266 cgen 265 top level 263 otime 2018-01-06 20:05:51 path <FS_TREE>/@snapshots/@06-01-2018-20:05_test1
id="${snap_path_name//[!0-9]}"
id: 0601201820051
local entry="${snap[@]:10:2} | ${snap_path_name}"
entries: 2018-01-06 20:05:51 | @snapshots/@06-01-2018-20:05_test1
when the comparison is executed,
bash considers the number starting with a 0 as an octal number,
Stupid interpreter...
so to fix it quickly, I removed the "0" at the beginning of the ids.
There was a problem hiding this comment.
I see, I still think you should just change to == instead of -eq, it was a bad choice on my side to use -eq in the first place as it treats numbers specially - IDs are strings and == should handle them just fine. Then there is no need to remove 0 from the beginning.
There was a problem hiding this comment.
good deduction and more elegant solution
after testing, error no longer appears
Found snapshot: 2018-01-06 23:00:37 | @racine/.snapshots/10/snapshot | single | timeline
Found snapshot: 2018-01-06 20:05:51 | @snapshots/@06-01-2018-20:05_test1
Found snapshot: 2018-01-06 20:00:00 | @racine/.snapshots/9/snapshot | single | timeline
|
if it's ok, i can merge |
|
Works on my side 👍 |
fix Snapper id too long #36