Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly validate node layers for mlp builds #266

Closed
danbraunai-apollo opened this issue Dec 20, 2023 · 0 comments · Fixed by #260
Closed

Explicitly validate node layers for mlp builds #266

danbraunai-apollo opened this issue Dec 20, 2023 · 0 comments · Fixed by #260
Assignees
Labels
bug Something isn't working priority-medium

Comments

@danbraunai-apollo
Copy link
Contributor

tests.test_build_graph.test_mnist_build_graph_invalid_node_layers currently passes (tests that out of order node layers won't build correctly), but the issue is that there is no explicit test for this before building the graph. The code will actually run until it gets to calculating the edges.

This should be fixed if we implement a SequentialMLP which would validate node layers on initialisation.

@danbraunai-apollo danbraunai-apollo added bug Something isn't working priority-medium labels Dec 20, 2023
@danbraunai-apollo danbraunai-apollo self-assigned this Dec 20, 2023
@danbraunai-apollo danbraunai-apollo changed the title (feature/unify) Explicitly validate node layers for mlp builds Explicitly validate node layers for mlp builds Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant