Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major Refactoring #260

Merged
merged 31 commits into from
Jan 19, 2024
Merged

Major Refactoring #260

merged 31 commits into from
Jan 19, 2024

Commits on Dec 18, 2023

  1. Make CI run on feature/unify

    @danbraunai-apollo
    danbraunai-apollo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    3d99d0e View commit details
    Browse the repository at this point in the history

  2. Fix dataset config discriminator and structure

    @danbraunai-apollo
    danbraunai-apollo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    ffe54b2 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Merge main into feature/unify

    @danbraunai-apollo
    danbraunai-apollo committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    215d96e View commit details
    Browse the repository at this point in the history

  2. Combine lm and mlp ablation scripts (#263) 

    * Combine lm and mlp ablation scripts

* Use sample graphs in ablation configs
    @danbraunai-apollo
    danbraunai-apollo authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    ec068e4 View commit details
    Browse the repository at this point in the history

  3. Combine lm_rib_build with mlp_rib_build (#264)

    @danbraunai-apollo
    danbraunai-apollo authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    cfec6ac View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/unify

    @danbraunai-apollo
    danbraunai-apollo committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    a829c11 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Move core functionality from experiments to rib package (#267) 

    * Move rib build and plot inside rib package

* Rename experiments to rib_scripts and update setup.py

* Move all ablation logic to rib/ablations.py

* Test update venv in CI

* Revert test change in CI

* Fix package finding in setup.py
    @danbraunai-apollo
    danbraunai-apollo authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d5fe2b5 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Make RibResults a pydantic model (#268) 

    * Make RibResults a pydantic model

* Save model config object instead of dict in RibResults
    @danbraunai-apollo
    danbraunai-apollo authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    fc5a793 View commit details
    Browse the repository at this point in the history

  2. Use MLP class for modular MLPs (#269)

    @danbraunai-apollo
    danbraunai-apollo authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    98e4aa6 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Convert InteractionRotation and Eigenvectors to pydantic models (#270)

    @danbraunai-apollo
    danbraunai-apollo authored Dec 22, 2023
    Configuration menu
    Copy the full SHA
    639b23a View commit details
    Browse the repository at this point in the history

  2. Refactor sequential transformer and tlens weight loader

    @danbraunai-apollo
    danbraunai-apollo committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    240963d View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Closes #266; EnsureMLP node_layers are valid

    @danbraunai-apollo
    danbraunai-apollo committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    b233d39 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Store edges in Edges pydantic model (#273) 

    * Store edges in Edges pydantic model

* Simplify edge_combiner
    @danbraunai-apollo
    danbraunai-apollo authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    1495fb3 View commit details
    Browse the repository at this point in the history

  2. Rename variables and clean docs (#274) 

    * Rename variables and clean docs

* Update rib_builder.py module docstring
    @danbraunai-apollo
    danbraunai-apollo authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    63fd9ff View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Merge branch 'main' into feature/unify

    @danbraunai-apollo
    danbraunai-apollo committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    fe27da6 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Allow running workflow manually in CI

    @danbraunai-apollo
    danbraunai-apollo committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    2e6ea65 View commit details
    Browse the repository at this point in the history

  2. Update pythia default configs

    @danbraunai-apollo
    danbraunai-apollo committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    536efdd View commit details
    Browse the repository at this point in the history

  3. Update setup for running distributed edges

    @danbraunai-apollo
    danbraunai-apollo committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    d88793f View commit details
    Browse the repository at this point in the history

  4. Remove plt.clf() at end of plot_rib_graph

    @danbraunai-apollo
    danbraunai-apollo committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    132196e View commit details
    Browse the repository at this point in the history

  5. Move ablation schedule from fn to instance methods (#281)

    @danbraunai-apollo
    danbraunai-apollo authored Jan 16, 2024
    Configuration menu
    Copy the full SHA
    bdf5216 View commit details
    Browse the repository at this point in the history

  6. Fix ablation result caching

    @danbraunai-apollo
    danbraunai-apollo committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    060f177 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Add attach to debugging config

    @danbraunai-apollo
    danbraunai-apollo committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e4e032a View commit details
    Browse the repository at this point in the history

  2. Minor doc fixes

    @danbraunai-apollo
    danbraunai-apollo committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ad5f050 View commit details
    Browse the repository at this point in the history

  3. Store calc_C_time and calc_edges_time in float

    @danbraunai-apollo
    danbraunai-apollo committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f66bb22 View commit details
    Browse the repository at this point in the history

  4. Improve naming and docs related to module_names

    @danbraunai-apollo
    danbraunai-apollo committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d9db9e8 View commit details
    Browse the repository at this point in the history

  5. Nix's unify clenaups (#280) 

    * ablations cleanups

* ignore old out files

* edge storing loop simplify

* merge model loading

* clean test configs

* revert load dataset chagne

* Fix naming and docs

* important fix

---------

Co-authored-by: Dan Braun <dan@apolloresearch.ai>
    @nix-apollo @danbraunai-apollo
    nix-apollo and danbraunai-apollo authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f9dad02 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into feature/unify

    @danbraunai-apollo
    danbraunai-apollo committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9928b49 View commit details
    Browse the repository at this point in the history

  7. Rename torch types (#284) 

    * Rename torch types

* Fix raw input torch types

* Fix tuple annotation for unknown emb size

* Fix docs and types
    @danbraunai-apollo
    danbraunai-apollo authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5e55800 View commit details
    Browse the repository at this point in the history

  8. Remove extra return_set arg (#286) 

    * Remove extra return_set arg and fix model_copy

* Move get_config functions to tests.utils
    @danbraunai-apollo
    danbraunai-apollo authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1cc9562 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Rename update_pydantic_model -> replace_pydantic_model

    @danbraunai-apollo
    danbraunai-apollo committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    bf4d8d4 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Combine Eigenvectors object with InteractionRotation (#290) 

    * Combine Eigenvectors object with InteractionRotation

* Address misc comments in PR #260

* Rename variables and update docs
    @danbraunai-apollo
    danbraunai-apollo authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    a44f992 View commit details
    Browse the repository at this point in the history