Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the LegacyFolder outside of Polly.Core #1083

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Mar 26, 2023

The issue or feature being addressed

In this PR we move the LegacyFolder outside of Polly.Core so it can be reused by other projects. Additionaly we add support for:

  • Records
  • Full set of nullability attributes

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2023

Codecov Report

Merging #1083 (39ea89e) into main (7688615) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
- Coverage   73.83%   73.80%   -0.04%     
==========================================
  Files         161      161              
  Lines        4086     4081       -5     
  Branches      775      775              
==========================================
- Hits         3017     3012       -5     
  Misses        864      864              
  Partials      205      205              
Flag Coverage Δ
linux 73.80% <100.00%> (-0.04%) ⬇️
macos 73.80% <100.00%> (-0.04%) ⬇️
windows 73.80% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/Polly.Core/Builder/ResilienceStrategyBuilder.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@martintmk martintmk merged commit 82c3467 into main Mar 27, 2023
@martintmk martintmk deleted the mtomka/legacy-support branch March 27, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants